Skip to content

Factor setup compiler actions - #1418

Merged
AntoinePrv merged 5 commits into
xtensor-stack:masterfrom
AntoinePrv:setup-compiler
Oct 1, 2026
Merged

AntoinePrv merged 5 commits into
xtensor-stack:masterfrom
AntoinePrv:setup-compiler

Conversation

@AntoinePrv

@AntoinePrv AntoinePrv commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Factor the setup compiler scripts as a Github action.
This is the first step, then if it goes well, I'd take it out in a separate repo in this org to reuse with xsimd-algorithm, xtensor...

@AntoinePrv

Copy link
Copy Markdown
Contributor Author

@serge-sans-paille what do you think?

@JohanMabille JohanMabille left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea!

@serge-sans-paille serge-sans-paille left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan of that work, thanks a bunch.
Minor nit, you may want to split qemu to an independent action, but really don't overdo it

compiler: gcc
version: '10'
target: aarch64-linux-gnu
qemu: 'true'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit strange to have qemu be part of the compiler setup, but I guess it's okay.
I wouldn't mind keeping it as a separate step though.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in term of separation of concerns this would be best to split it.
But I kept it pragmatic: when we need to cross compile, we'll need qemu, so let's avoid too much yamling.
I'd keep it this way for now, but we can always split it later.

@AntoinePrv
AntoinePrv merged commit 185d5a8 into xtensor-stack:master Oct 1, 2026
88 checks passed
@AntoinePrv
AntoinePrv deleted the setup-compiler branch October 1, 2026 09:25
@AntoinePrv

Copy link
Copy Markdown
Contributor Author

This can be used with

uses: xtensor-stack/xsimd/.github/actions/setup-cross-compiler-apt@main

I'd keep it in this repo for now, to give it a bit of mileage before putting it on its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants