Factor setup compiler actions - #1418
Conversation
2b70cd9 to
dbbd732
Compare
dbbd732 to
5044c09
Compare
|
@serge-sans-paille what do you think? |
serge-sans-paille
left a comment
There was a problem hiding this comment.
Big fan of that work, thanks a bunch.
Minor nit, you may want to split qemu to an independent action, but really don't overdo it
| compiler: gcc | ||
| version: '10' | ||
| target: aarch64-linux-gnu | ||
| qemu: 'true' |
There was a problem hiding this comment.
It's a bit strange to have qemu be part of the compiler setup, but I guess it's okay.
I wouldn't mind keeping it as a separate step though.
There was a problem hiding this comment.
Yes, in term of separation of concerns this would be best to split it.
But I kept it pragmatic: when we need to cross compile, we'll need qemu, so let's avoid too much yamling.
I'd keep it this way for now, but we can always split it later.
|
This can be used with I'd keep it in this repo for now, to give it a bit of mileage before putting it on its own. |
Factor the setup compiler scripts as a Github action.
This is the first step, then if it goes well, I'd take it out in a separate repo in this org to reuse with
xsimd-algorithm,xtensor...