Skip to content

Keep thousands separator in record and site counts - #1971

Open
sanketio wants to merge 1 commit into
xwp:developfrom
sanketio:fix/count-thousands-separator
Open

Keep thousands separator in record and site counts#1971
sanketio wants to merge 1 commit into
xwp:developfrom
sanketio:fix/count-thousands-separator

Conversation

@sanketio

@sanketio sanketio commented Aug 27, 2026

Copy link
Copy Markdown

Fixes #1477.

total_items_i18n and the network admin site count formatted an already-separated number with %d, truncating it at the first comma — 1,501 items rendered as 1 items. Switched both to %s, matching WP_List_Table::pagination(). The network count has no test because is_network_admin() reads a constant the suite cannot set per-test.

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

Release Changelog

  • Fix: Keep the thousands separator in the records table item count and the network admin site count.

@PatelUtkarsh

Copy link
Copy Markdown
Member

@sanketio Thanks for PR!

Can you update pr desc with template as per https://github.com/xwp/stream/blob/develop/.github/PULL_REQUEST_TEMPLATE.md?

@sanketio

Copy link
Copy Markdown
Author

Updated the description to use the template.

@sanketio
sanketio force-pushed the fix/count-thousands-separator branch from 5aa2ee8 to 104f697 Compare August 27, 2026 07:19
@PatelUtkarsh

Copy link
Copy Markdown
Member

That was quick; Can you write Haiku for this PR changes in comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Item count above table cuts off commas when updated via JS

2 participants