Keep thousands separator in record and site counts - #1971
Open
sanketio wants to merge 1 commit into
Open
Conversation
Member
|
@sanketio Thanks for PR! Can you update pr desc with template as per https://github.com/xwp/stream/blob/develop/.github/PULL_REQUEST_TEMPLATE.md? |
Author
|
Updated the description to use the template. |
sanketio
force-pushed
the
fix/count-thousands-separator
branch
from
August 27, 2026 07:19
5aa2ee8 to
104f697
Compare
Member
|
That was quick; Can you write Haiku for this PR changes in comment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1477.
total_items_i18nand the network admin site count formatted an already-separated number with%d, truncating it at the first comma —1,501 itemsrendered as1 items. Switched both to%s, matchingWP_List_Table::pagination(). The network count has no test becauseis_network_admin()reads a constant the suite cannot set per-test.Checklist
contributing.md).Release Changelog