Repository navigation
fix: ignore functions without mutating input objects - #233
Merged
redonkulus merged 1 commit intoOct 22, 2026
Merged
redonkulus merged 1 commit into
redonkulus merged 1 commit into
Conversation
Collaborator
|
Thank you for contributing! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
ignoreFunction: truecurrently deletes function-valued properties from the input object. Besides modifying caller-owned data, this throws for frozen objects and turns functions in dense arrays into holes rather than the null values produced by JSON.stringify.Let JSON.stringify handle function values returned by the replacer instead of deleting properties. This preserves the documented JSON-like behavior of ignoreFunction while retaining the original objects and arrays.
Three regression tests fail before the fix: nested-object mutation, frozen objects, and functions in arrays. All 103 tests pass afterward (
node --test test/unit/*.js), and git diff --check passes.