chore(compute/v1): add missing AutoHealingPolicy in create/update requests #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This repo is synced from the other source. You proposal that changes the API won’t be merged. |
Author
|
@nikolaymatrosov, ok, I understand. Is it possible to ask someone from Yandex.Cloud to make the same changes to the upstream repository? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While exploring terraform provider, I found that there is no auto_healing_policy field in yandex_compute_instance_group. The provider uses an CreateInstanceGroupRequest and an UpdateInstanceGroupRequest from github.com/yandex-cloud/go-genproto/yandex/cloud/compute/v1/instancegroup. As I understand it, that code was generated from Protobuf structures in this repository. So, I added these missing fields to update terraform provider after these changes are merged.
The yandex_kubernetes_node_group has the same problem, I think. auto_healing_policy is missing, while other policies are present. But these are different objects, although after creating a node group, a instance group will also be created with a managed label (managed-kubernetes-node-group-id). I can suggest that the
/managed-kubernetes/v1/nodeGroupsAPI passes some values to/compute/v1/instanceGroups. If you know where I can create a ticket to the Yandex Cloud team with a request to support auto_healing_policy in the node group API, I would be glad to know.