Skip to content

Operation meta on error #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PeppaTheC merged 1 commit into from
Mar 27, 2025
Merged

Operation meta on error #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 17 additions & 19 deletions yandexcloud/_operation_waiter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,44 +63,42 @@ def get_operation_result(
operation_result: OperationResult[ResponseType, MetaType] = OperationResult(operation)
created_at = datetime.fromtimestamp(operation.created_at.seconds)
message = (
"Running Yandex.Cloud operation. ID: {id}. "
"Description: {description}. Created at: {created_at}. "
"Created by: {created_by}."
)
message = message.format(
id=operation.id,
description=operation.description,
created_at=created_at,
created_by=operation.created_by,
f"Running Yandex.Cloud operation. ID: {operation.id}. "
f"Description: {operation.description}. Created at: {created_at}. "
f"Created by: {operation.created_by}."
)

if meta_type and meta_type is not Empty:
unpacked_meta = meta_type()
operation.metadata.Unpack(unpacked_meta)
operation_result.meta = unpacked_meta
message += f" Meta: {unpacked_meta}."

logger.info(message)

result = wait_for_operation(sdk, operation.id, timeout=timeout)
if result is None:
return OperationError(message="Unexpected operation result", operation_result=OperationResult(operation))
raise OperationError(message="Unexpected operation result", operation_result=operation_result)

if result.error and result.error.code:
error_message = (
"Error Yandex.Cloud operation. ID: {id}. Error code: {code}. Details: {details}. Message: {message}."
)
error_message = error_message.format(
id=result.id,
code=result.error.code,
details=result.error.details,
message=result.error.message,
f"Error Yandex.Cloud operation. ID: {result.id}. "
f"Error code: {result.error.code}. "
f"Details: {result.error.details}. "
f"Message: {result.error.message}. "
f"Meta: {operation_result.meta}."
)
logger.error(error_message)
raise OperationError(message=error_message, operation_result=OperationResult(operation))
raise OperationError(message=error_message, operation_result=operation_result)

log_message = f"Done Yandex.Cloud operation. ID: {operation.id}."
if response_type and response_type is not Empty:
unpacked_response = response_type()
result.response.Unpack(unpacked_response)
operation_result.response = unpacked_response
log_message += f" Response: {unpacked_response}."
log_message += f" Response: {operation_result.response}."
log_message += f" Meta: {operation_result.meta}."

logger.info(log_message)
return operation_result

Expand Down
Loading