Open trades: where each running trade stands between its stop and its target - #124
Merged
Merged
Conversation
… ignores the session in progress Section 3, Open trades: every signal bought and not yet resolved, with bought at and when, stop loss, take profit, last close, gain or loss so far, days held, and a bar showing where the last close stands between the stop loss and the take profit with the buy price as a tick; the closed trades become section 4 with the tally over resolved trades only, and the instruction in section 1 points a reader who is in to section 3. tools/evaluate_signals.py ignores bars dated on the run's own UTC day before 21:00 UTC and rows without a full OHLC: the 06:00 UTC build had scored Yahoo's partial row for a session that had not opened. Tests, wiki 01 and 04, README, changelog. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
You bought MO on the signal and could not see on the page whether the trade had reached its take profit or its stop loss. It was in the results table as one row among the closed ones. Now it has a section of its own.
3. Open trades. Every signal bought and not yet resolved: bought at (and when), stop loss, take profit, last close (and when), gain or loss so far, days held, and a bar with the stop loss at the red end, the take profit at the green end, the buy price as a tick and the last close as the blue dot. One sentence above it says when a trade leaves: the morning after its low touches the stop, its high touches the target, or 60 sessions pass. A signal from the last scan shows as "Pending, at the next open". The instruction in section 1 now ends with "Once you are in, follow the trade in section 3."
4. Closed trades: were we right? Unchanged apart from the number and a tally over resolved trades only.
Fix in the evaluator. Today's live build, at 06:09 UTC, showed MO "bought at 69.84 on 2026-09-17", hours before the US session opened: Yahoo's chart already carried a partial row for the day.
tools/evaluate_signals.pynow ignores bars dated on the run's own UTC day before 21:00 UTC and rows without a full OHLC, so a signal reported in the morning stays pending until the next run, when yesterday's open, its fill, is final. Tests cover the cutoff before and after the close and a half-written row.Checked in the browser with today's live data: four open trades with their bars, three closed.
Test plan
testsworkflow on this PR🤖 Generated with Claude Code