Skip to content

Fix: workflow_job completed step status can be pending - #335

Merged
yanyongyu merged 1 commit into
yanyongyu:masterfrom
Eliezergh:eliezergh-fix-workflow-job-step-status-pending
Oct 30, 2026
Merged

yanyongyu merged 1 commit into
yanyongyu:masterfrom
Eliezergh:eliezergh-fix-workflow-job-step-status-pending

Conversation

@Eliezergh

Copy link
Copy Markdown
Contributor

Fixes #334

GitHub can send workflow_job completed events whose steps[].status is "pending", which the published OpenAPI schema doesn't allow, so webhooks.parse raised a ValidationError.

  • Add a schema_overrides patch in pyproject.toml adding "pending" to the step status enum.
  • Regenerate schema packages with scripts/run-codegen.sh (generated files and versions.lock only).
  • Add a workflow_job completed sample (with in_progress and pending steps) to tests/test_webhooks.

tests/test_webhooks passes locally.

@yanyongyu yanyongyu added bug Something isn't working schema schema related WebHook labels Oct 29, 2026
@yanyongyu yanyongyu changed the title 🐛 Fix: workflow_job completed step status can be pending Fix: workflow_job completed step status can be pending Oct 30, 2026
@yanyongyu
yanyongyu merged commit ba2329c into yanyongyu:master Oct 30, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working schema schema related WebHook

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workflow_job "completed" webhook can report steps[].status: "pending", rejected by schema

2 participants