Conversation
github-actions
Bot
added
size:XXL
vouch:unvouched
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f41e73e7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const UPDATE_DOWNLOAD_CHANNEL = "desktop:update-download"; | ||
| const UPDATE_INSTALL_CHANNEL = "desktop:update-install"; | ||
| const DESKTOP_SCHEME = "cut3"; | ||
| const DESKTOP_SCHEME = "rowl"; |
There was a problem hiding this comment.
Changing the desktop protocol scheme to rowl means packaged renderer requests will originate from rowl://app, but the server still only whitelists cut3://app in apps/server/src/networking.ts (DESKTOP_APP_ORIGIN). In desktop mode with auth enabled, websocket upgrades that include Origin: rowl://app will be rejected as a forbidden origin, which can prevent the desktop client from connecting to the backend at all. Update the server allowlist in the same change (or temporarily accept both origins).
Useful? React with 👍 / 👎.
| const SCRIPT_TERMINAL_COLS = 120; | ||
| const SCRIPT_TERMINAL_ROWS = 30; | ||
| const WORKTREE_BRANCH_PREFIX = "cut3"; | ||
| const WORKTREE_BRANCH_PREFIX = "rowl"; |
There was a problem hiding this comment.
The web client now generates temporary worktree branches with rowl/<8hex>, but backend temporary-branch detection still matches only cut3/<8hex> in apps/server/src/orchestration/Layers/ProviderCommandReactor.ts. As a result, first-turn temporary branches are no longer recognized as temporary, so the auto-rename path (maybeGenerateAndRenameWorktreeBranchForFirstTurn) is skipped and threads keep random bootstrap branch names. Either keep the old prefix here or make the backend accept both prefixes.
Useful? React with 👍 / 👎.
1 participant
No description provided.