hoistingLimits - optimize hoisting when transitive dependency matches root one#7196
Open
Knagis wants to merge 4 commits into
Open
hoistingLimits - optimize hoisting when transitive dependency matches root one#7196Knagis wants to merge 4 commits into
Knagis wants to merge 4 commits into
Conversation
3 tasks
Member
|
@Knagis Thank you for the followup PR! Does it handle root workspace only or does it support non-root workspaces too? |
Author
|
i think this should work with either, it doesn't add any special meaning to root, instead it makes all hoist border nodes unique. |
Member
|
I see, good idea! Thank you, looks good! |
larixer
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up on #7189 - this version makes sure that the transitive dependencies are still hoisted up to the hoist border.
It also adds a skipped unit test for potential future fix - when a transitive dependency matches the root one, it can be "hoisted" to root - it isn't hoisting since the dependency already exists. The PR does not include an implementation for this scenario.
Resolves #6662