Fix scoped npmMinimalAgeGate fallback#7202
Open
sjh9714 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Fixes #7192.
Scoped
npmMinimalAgeGateentries currently materialize the default1dvalue even when the scope leaves the setting unset. This preventsyarn config get npmScopes --jsonand scoped install resolution from inheriting a global disabled gate (npmMinimalAgeGate: 0).How did you fix it?
I added a fallback setting hook for transformed configuration output, made the scoped npm gate keep
undefinedwhen unset, and wired that scoped setting to fall back to the globalnpmMinimalAgeGatevalue. I also added regression coverage for the JSON-visible config value and the scoped install behavior when the global gate is disabled.Testing
yarn test:unit --runInBand packages/yarnpkg-core/tests/Configuration.test.ts -t "scoped npmMinimalAgeGate"yarn test:unit --runInBand packages/yarnpkg-core/tests/Configuration.test.tsyarn build:cliyarn workspace acceptance-tests test:integration --runInBand sources/features/npmMinimalAgeGate.test.ts -t "unset scope gate inherits"yarn typecheck:allyarn version checkyarn test:lintChecklist