Added support to add/customize request options (Ex: timeout, proxy etc.)#32
Open
maulik07 wants to merge 3 commits intoyaronn:masterfrom
Open
Added support to add/customize request options (Ex: timeout, proxy etc.)#32maulik07 wants to merge 3 commits intoyaronn:masterfrom
maulik07 wants to merge 3 commits intoyaronn:masterfrom
Conversation
added 2 commits
September 20, 2016 11:32
…while sending ws requests. Options could be passed as constructor args to http handler.
maulik07
changed the title
|
Could be strange but in my case I need to edit headers. Should it be more interesting to replace 'jsonConcat' by an extend functionality so that we can replace any options? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to Issue #31
Addresses PR #8
Added support to customize and tweak all available options listed under request module for node: Available Options.
The options could be passed in as a JSON Object to constructor argument of Http handler which will in-turn club these options with the required/default ones while sending a request.
The constructor argument could be omitted/skipped, under which case the API sticks to its current core functionality.
Sample Usage:
var handlers = [ new Security({}, [new UsernameToken({username: "yaron", password: "1234"})]) , new Http({timeout: 3000}) ]