Add OpenTelemetry lib and metric-interfaces#588
Closed
maladetska wants to merge 17 commits intoydb-platform:mainfrom
Closed
Add OpenTelemetry lib and metric-interfaces#588maladetska wants to merge 17 commits intoydb-platform:mainfrom
maladetska wants to merge 17 commits intoydb-platform:mainfrom
Conversation
maladetska
commented
Feb 17, 2026
maladetska
force-pushed
the
METRICS-0
branch
from
beec910 to
a102d53
Compare
Contributor
🌋 SLO Test ResultsStatus: 🟢 2 workloads tested • All passed
Generated by ydb-slo-action |
maladetska
commented
Feb 24, 2026
maladetska
commented
Feb 24, 2026
maladetska
changed the title
Gazizonoki
requested changes
Feb 24, 2026
Collaborator
Gazizonoki
left a comment
Gazizonoki
left a comment
There was a problem hiding this comment.
Мне кажется папка open_telemetry в корне не самая удобная штука. Это же плагин к sdk, может сделаем папку plugins(extensions или еще какое-то имя) и туда положим все такие штуки (экспортеры метрик, трейсов, логов для конкретных систем и т. д.)?
И с метриками, оно вообще используется по коду? SDK уже собирает много метрик, в задаче с метриками это и есть главная сложность, как аккуратно перевести все на общий интерфейс и выкинуть library/cpp/monlib уже к черту из внешнего репозитория (это так-то внутренняя штука, вылезла в open-source ydb-cpp-sdk из-за неаккуратности)
added 2 commits
March 1, 2026 02:20
Gazizonoki
reviewed
Mar 10, 2026
Gazizonoki
requested changes
Mar 20, 2026
Collaborator
Gazizonoki
left a comment
Gazizonoki
left a comment
There was a problem hiding this comment.
Было бы неплохо example с метриками завести еще
maladetska
force-pushed
the
METRICS-0
branch
2 times, most recently
from
a0abdba to
ec3df8e
Compare
maladetska
force-pushed
the
METRICS-0
branch
3 times, most recently
from
4fec641 to
a78a18b
Compare
maladetska
force-pushed
the
METRICS-0
branch
2 times, most recently
from
7cbed5c to
9c46b67
Compare
Gazizonoki
requested changes
Mar 30, 2026
Collaborator
Gazizonoki
left a comment
Gazizonoki
left a comment
There was a problem hiding this comment.
А что с stats.h будет?
Gazizonoki
reviewed
Apr 1, 2026
added 3 commits
April 2, 2026 10:47
…an, remove TQuerySpan and TQueryMetrics, modify TClientOperationStatCollector constructor
…ion, other_sql -> ydb
Gazizonoki
reviewed
Apr 7, 2026
added 2 commits
April 8, 2026 14:34
… make attributes freecase
KirillKurdyukov
approved these changes
Apr 13, 2026
This was
linked to
issues
Apr 24, 2026
Collaborator
|
Merged in this PR: ydb-platform/ydb#37957 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.