Repository navigation
feat: export the store alone as yeoman-environment/store, without execa - #871
Merged
Merged
Conversation
`yeoman-environment/store` exports the Store and its types without the environment: importing the store loads 32 modules, the index 400. execa, which the store imported through the lookup of the global npm paths, is loaded at the first command only: a lookup given the paths of its packages does not load it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Importing the Store from the package loads the whole index: the environment, mem-fs-editor, the adapter and inquirer, the conflicter, commander… A tool that only looks up and reads generators (
lookupSync,getMeta,requireSibling) does not need them.yeoman-environment/store: a subpath exporting the Store (asStoreand as default) and the types of the store (StoreGeneratorMeta,StoreLookupOptions, …), without the environment.yarn global dir,npm root -g).execaOutputnow loads it at its first command: a lookup given the paths of its packages does not load it. execa is kept rather thanchild_process, for the.cmdof npm and yarn on Windows.Benchmark
Modules loaded by an import:
dist/store.jsyeoman-environment/storeyeoman-environmentTest plan
npm test(eslint, prettier, tsc, the tests)lookupSyncwithpackagePathsand arequireSiblingthroughyeoman-environment/store, without loading execa🤖 Generated with Claude Code