Repository navigation
refactor: organize the modules by the environment, the store, the cli and the utils - #874
Merged
Merged
Conversation
… and the utils - environment/: environment-base.ts, environment-full.ts, composed-store.ts, commit.ts, package-manager.ts and resolve.ts. - store/: the store in store.ts, lookup.ts, module-lookup.ts and namespace.ts; lookupGenerator, which uses a store, in lookup-generator.ts, so lookup.ts no longer imports the store. index.ts exports them to the other modules of the package, public.ts is yeoman-environment/store, in place of store-export.ts. - cli/: command.ts and commands.ts, next to the bin, creating the environment without importing the index. - util/: util.ts split into args.ts, exec.ts, object.ts and regexp.ts. The modules import no other at runtime in a cycle. The exports of the package are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mshima
force-pushed
the
reorganize-modules
branch
from
October 21, 2026 13:37
4c01a03 to
d2f85cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 17 modules of
srcwere mostly at its root, the store and the lookup importing each other, and a util importing the environment. They are organized by what they are about:store.ts;index.tsonly exports the store and its lookups to the other modules of the package, which import the folder by it;public.tsis the module ofyeoman-environment/store(the store asStoreand default, and its types), in place ofsrc/store-export.ts.lookupGenerator, which uses a store, moves tolookup-generator.ts, so the lookup no longer imports the store.environment-full.ts, no longer importing the index that re-exports them.util.tssplit by subject.No module imports another at runtime in a cycle. The exports of the package are unchanged (the names exported by the index compared),
yeoman-environment/storeloads 33 modules (32 before,public.jsadded), and git follows the renames.Supersedes #872.
Test plan
npm test(eslint, prettier, tsc, the tests)npm run build, the bin (--version), the exports of the index, the modules ofyeoman-environment/store🤖 Generated with Claude Code