Type check with pyrefly, and fix what it found

.github/workflows/typecheck.yml

@@ -0,0 +1,21 @@
+name: Type check
+
+on: [pull_request]
+
+jobs:
+  pyrefly:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+      - run: pipx install poetry
+      - name: Set up Python
+        uses: actions/setup-python@v4
+        with:
+          python-version: "3.10"
+          cache: poetry
+      - name: Install Python dependencies
+        run: poetry install --no-root
+      - name: Type check with pyrefly
+        run: poetry run pyrefly check

pyproject.toml

@@ -18,7 +18,12 @@ requests-toolbelt = "^1.0.0"
 
 [tool.poetry.group.dev.dependencies]
 ruff = "^0.8.3"
+pyrefly = "^1.2.0"
 
 [build-system]
 requires = ["poetry-core"]
 build-backend = "poetry.core.masonry.api"
+
+[tool.pyrefly]
+project-includes = ["yeti"]
+project-excludes = ["tests"]

yeti/api.py

@@ -120,7 +120,7 @@ def do_request(
         if json_data and body:
             raise ValueError("You must provide either json or body, not both.")
 
-        request_kwargs = {}
+        request_kwargs: dict[str, Any] = {}
 
         if headers:
             request_kwargs["headers"] = headers
@@ -241,7 +241,7 @@ def search_indicators(
                 "You must provide one of name, indicator_type, pattern, description, or tags."
             )
 
-        query = {}
+        query: dict[str, Any] = {}
         if name:
             query["name"] = name
         if pattern:
@@ -328,7 +328,7 @@ def search_entities(
         if not any([name, entity_type, description]):
             raise ValueError("You must provide one of name, type, or description.")
 
-        query = {}
+        query: dict[str, Any] = {}
         if name:
             query["name"] = name
         if entity_type:
@@ -448,7 +448,7 @@ def search_observables(
         Returns:
           The response from the API; a dict representing the observable.
         """
-        query = {"value": value}
+        query: dict[str, Any] = {"value": value}
         if tags:
             query["tags"] = tags
         params = {"query": query, "count": count, "page": page}
@@ -526,7 +526,7 @@ def new_entity(
         Returns:
           The response from the API; a dict representing the entity.
         """
-        params = {"entity": entity}
+        params: dict[str, Any] = {"entity": entity}
         if tags:
             params["tags"] = tags
         response = self.do_request(
@@ -660,7 +660,7 @@ def search_dfiq(
         Returns:
             The response from the API; a dict representing the DFIQ object.
         """
-        query = {
+        query: dict[str, Any] = {
             "name": name,
         }
 
@@ -669,7 +669,7 @@ def search_dfiq(
         if dfiq_tags:
             query["dfiq_tags"] = dfiq_tags
 
-        params = {
+        params: dict[str, Any] = {
             "query": query,
             "count": count,
             "page": page,
@@ -751,7 +751,7 @@ def download_dfiq_archive(self, dfiq_type: str | None = None) -> bytes:
         Returns:
           The archive contents as bytes.
         """
-        params = {"count": 0}
+        params: dict[str, Any] = {"count": 0}
         if dfiq_type:
             params["query"] = {"type": dfiq_type}
         response = self.do_request(