ci: enable full powerset for feature-soundness clippy#4034
Closed
Copilot wants to merge 2 commits intofeat/cargo-hack-feature-soundnessfrom
Closed
ci: enable full powerset for feature-soundness clippy#4034Copilot wants to merge 2 commits intofeat/cargo-hack-feature-soundnessfrom
Copilot wants to merge 2 commits intofeat/cargo-hack-feature-soundnessfrom
Conversation
1 task
Co-authored-by: Madoshakalaka <44753941+Madoshakalaka@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace hand-maintained feature-soundness scripts with cargo-hack
ci: enable full powerset for feature-soundness clippy
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature-soundness job was excluding
test,serde, andnot_browser_envfrom the powerset, covering only 18 of yew's 130 possible feature combinations.Changes
clippy.yml: Remove--exclude-features test,serde,not_browser_envfrom bothdevandreleasefeature-soundness steps, expanding yew's checked combinations from 16 (2⁴) to 128 (2⁷) per profileNotes
The three re-included features are safe to add to the powerset:
cfg(featureusagesserdeimplicit-clone/serdenot_browser_envtest#[cfg(all(feature = "csr", ...))]Estimated timing: baseline run (18 combos) took ~60 s for the lint step; full powerset (130 combos) is ~7× more but the three new features don't gate any compilation paths, so incremental caching keeps the realistic estimate at ~2–4 min per profile — comparable to unit/integration tests.
After #4027: adding
yew-link(3 features → 8 combinations) brings the total to 138, a ~6% increase independent of this change.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.