fail mmap::open when ::mmap returns MAP_FAILED - #2511
Open
metsw24-max wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the posix branch of
detail::mmap::openonly testsMAP_FAILEDas part of the empty-file case, so a failed mapping of a non-empty file leaves the sentinel inaddr_andopen()still returns true.is_open()comparesaddr_against nullptr alone, so callers pass the guard anddata()hands back(const char *)-1, whichhandle_file_requestand theset_file_contentpath inprocess_requestboth feed to a content provider asdata() + offset, withoffsetcoming from the client's Range header and the length bounded by the fstat size rather than by any mapping. the windows branch already closes and fails on every mapping error, so this mostly brings posix into line with it. mapping a directory is the easiest way to reach the failure, since::openandfstatsucceed there and::mmapdoes not, and that is what the added test uses.