-
Notifications
You must be signed in to change notification settings - Fork 1
YPE-1332: Render introduction chapter #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cameronapak
wants to merge
23
commits into
main
Choose a base branch
from
YPE-1332-react-sdk-bible-reader-render-introduction-chapter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,069
−245
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
0e9edee
Feat: Add intro chapter button to bible picker
cameronapak c58cd20
Refactor bible reader to conditionally render header
cameronapak 46d765b
Fix: Conditionally render grid columns in Bible reader toolbar
cameronapak 2443fdf
Fix: Display chapter title or "Intro" in picker
cameronapak b72671c
Add '.ili1' CSS class to bible reader styles
cameronapak 4a3f615
fix: Correct typo in bible reader styles
cameronapak 7b05d1e
Update bible reader styles with new CSS classes
cameronapak e73ae5e
Add styling for verse labels
cameronapak 8be19f3
Make the font of the h1 Bible book and number be our serif font
cameronapak 2ae9aa8
Add USFM styling for reader component
cameronapak 92b4bd8
In Arabic/Hebrew Bible versions, this puts the footnote reference
cameronapak 0781b1d
fix(ui): show unavailable message when chapter doesn't exist in selected
cameronapak dfba9b4
fix(ui): improve intro chapter detection and add missing test coverage
cameronapak 9dc55a9
Fix: Wait for intro label in bible reader story
cameronapak 23ec149
Update bible reader intro chapter story
cameronapak 63e5a27
fix(ui): add top margin to section headings and intro chapter story
cameronapak 1cd3e71
Refactor bible picker to use chapter label
cameronapak e19bcab
rm unnecessary story test
cameronapak d28b668
Refactor bible reader CSS for clarity and consistency
cameronapak 570ae82
Align bible reader text to start
cameronapak 3b905f4
Refactor bible reader CSS margins and indents
cameronapak c6db4e7
Refactor: Adjust bible reader list indentations
cameronapak aa95330
Add spacing to introduction list items
cameronapak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (non-blocking): Is there a reason we're not abstracting this into a helper function?