Refactor verse rendering and footnote extraction#152
Draft
jaredhightower-youversion wants to merge 1 commit intomainfrom
Conversation
This commit refactors the `VerseTextHtml` component and the `extractNotesFromWrappedHtml` utility function. The `VerseTextHtml` component now logs `placeholders` for debugging and places the `contentRef` div at the end of the returned JSX. The `extractNotesFromWrappedHtml` function now adds a `data-verse-footnote` attribute to footnote elements and removes the `yv-n` class. The logic for handling spacing around removed footnotes has been commented out, as it was causing issues.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the
VerseTextHtmlcomponent and theextractNotesFromWrappedHtmlutility function.The
VerseTextHtmlcomponent now logsplaceholdersfor debugging and places thecontentRefdiv at the end of the returned JSX.The
extractNotesFromWrappedHtmlfunction now adds adata-verse-footnoteattribute to footnote elements and removes theyv-nclass. The logic for handling spacing around removed footnotes has been commented out, as it was causing issues.