This repository was archived by the owner on Jan 10, 2020. It is now read-only.
Not possible to include js files referenced by relative path in test files#2
Open
samyhrer wants to merge 3 commits into
Open
Not possible to include js files referenced by relative path in test files#2samyhrer wants to merge 3 commits into
samyhrer wants to merge 3 commits into
Conversation
Returning absolute paths broke the ability to include js files referenced by relative path in test files
Member
|
I'll take a look at this, this was added to support Windows so I need to make sure this doesn't break that ;) |
Member
|
Do you have a test case for this? I've tested it locally without modification and it seems to work as expected. I'd like to see what I'm missing with this. |
Author
|
I'm having a setup with this directory structure and these files: /src/test.js Running Contents of rel.html: <!DOCTYPE HTML>
<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<title>Basic Usage Example</title>
<script src="http://yui.yahooapis.com/3.6.0/build/yui/yui-min.js"></script>
</head>
<body>
<script src="../src/test.js"></script>
</body>
</html>The use case is to be able to reference both test-scripts as well as other js-dependencies by relative path |
…atform On the windows platform it was not possible to start test this way: grover <path to test file> <path to test file>
Glob patterns such as /**/*.html was not supported on *nix-platforms. This is now introduced by the -g <pattern> argument.
|
That works for me too. Thx samyrer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning absolute paths broke the ability to include js files
referenced by relative path in test files