Draft
Conversation
…ilds - Add Cursor Cloud specific instructions section to AGENTS.md with non-obvious dev environment caveats (Node v24, sharp build approval, no external services needed, no test framework) - Add pnpm.onlyBuiltDependencies to package.json to allow sharp and esbuild postinstall scripts to run non-interactively Co-authored-by: Yu Le <yuler@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces Cursor Cloud specific instructions to AGENTS.md and configures pnpm.onlyBuiltDependencies in package.json for sharp and esbuild. The review feedback suggests improving the Node.js version management by using nvm use without a hardcoded version to automatically reference .nvmrc, and adding a trailing newline to package.json for POSIX compliance.
|
|
||
| ## Cursor Cloud specific instructions | ||
|
|
||
| - **Node.js**: `.nvmrc` specifies `v24`. Use `source ~/.nvm/nvm.sh && nvm use 24` before running any commands. |
Contributor
There was a problem hiding this comment.
To make this instruction more robust and prevent it from becoming outdated if .nvmrc is updated, you can use nvm use without specifying the version number. It will automatically pick up the version from the .nvmrc file.
Suggested change
| - **Node.js**: `.nvmrc` specifies `v24`. Use `source ~/.nvm/nvm.sh && nvm use 24` before running any commands. | |
| - **Node.js**: `.nvmrc` specifies `v24`. Use `source ~/.nvm/nvm.sh && nvm use` before running any commands. |
| "pnpm": { | ||
| "onlyBuiltDependencies": ["sharp", "esbuild"] | ||
| } | ||
| } No newline at end of file |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets up the Cursor Cloud development environment for this Astro personal site.
Changes
AGENTS.md: Added## Cursor Cloud specific instructionssection with non-obvious caveats for future cloud agents (Node v24 via nvm, sharp build approval, dev server config, no external services required, no test framework).package.json: Addedpnpm.onlyBuiltDependenciesto allowsharpandesbuildpostinstall scripts to run non-interactively, avoiding the interactivepnpm approve-buildsprompt.Verification
pnpm check— 0 errors, 0 warningspnpm build— 27 pages built successfully with image optimizationpnpm dev— Dev server running on port 4321, homepage / blog posts / workouts pages all render correctly