Add option to wrap embedded file with <details> disclosure element#33
Open
kupietools wants to merge 2 commits intoyusanshi:masterfrom
Open
Add option to wrap embedded file with <details> disclosure element#33kupietools wants to merge 2 commits intoyusanshi:masterfrom
kupietools wants to merge 2 commits intoyusanshi:masterfrom
Conversation
Added optional "collapsible" attribute. Collapsible=open or collapsible=closed will wrap the embedded file with <details class="emgithub-details"><summary class="emgithub-summary">[file title]</summary>[file contents, as normal]</details>
Owner
|
Thanks for your suggest and sorry for my late reply :) The idea sounds great but I believe it should be tweaked before being merged into the main branch:
|
Include info on difference from upstream version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @yusanshi, thanks for this useful script. I've added a feature I needed, so I thought you might want to consider it for inclusion in the main.
I added an optional "collapsible" attribute. Adding
collapsible=openorcollapsible=closedto the parameters you call the script with will wrap the embedded file with<details class="emgithub-details"><summary class="emgithub-summary">[file title]</summary>above the file's contents, then wrap it up with a</details>below, with the default state open or closed, as defined by the chosen value.