Conversation
The committed schemas had drifted from their TypeScript sources; this is a plain regeneration with no source changes. Two user-visible effects: - entrypoint.not_found was still typed as an array of RouteRule, but it became a rules string block. The config editor rejected the block form that config.example.yml documents. - RuleDo missed the named option block for middleware actions in rules. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
@taljaards is attempting to deploy a commit to the GoDoxy Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe ChangesRuleDo schema documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The regenerated schemas document supported named middleware and option-block syntax consistently, reducing validation drift without changing runtime source behavior. No merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit hops through schemas bright Comment |
|
Closing — this is obsolete. 7453ffa regenerated the same schemas and picked up both drifts this PR was fixing: I verified there is nothing left to contribute: regenerating all seven schemas on current The stacked #20 no longer depends on this one: I merged |
The committed JSON schemas had drifted from their TypeScript sources. This is a plain regeneration — no source changes.
Why it matters
Two of the drifts are user-visible in the config editor:
entrypoint.not_foundis still typed as an array ofRouteRule, but it became a rules string block. The editor rejects the block form thatconfig.example.ymldocuments.RuleDois missing the named option block, so middleware actions in rules do not validate.How
The
gen-schemarecipe, vianpxrather thanbunx(no bun on my machine — same generator, same flags):All seven schemas were regenerated; only three changed. The generator reproduces the other four byte-for-byte, which is what gives me confidence the diff is drift and not tool-version noise.
The gitignored
*.schema.deref.jsonstep was skipped —deref.tsimportsbun.🤖 Generated with Claude Code
Note
Regenerate stale
godoxyJSON schemasRefreshes the generated JSON Schema documents for
godoxyconfig, Docker routes, and routes to current serialized versions. This is a code generation update with no hand-written logic changes.Macroscope summarized b02f195.
Summary by CodeRabbit
middleware RealIPusage in routing rules.