Skip to content

add more type support#421

Open
yuzawa-san wants to merge 9 commits into
masterfrom
more-types-2026
Open

add more type support#421
yuzawa-san wants to merge 9 commits into
masterfrom
more-types-2026

Conversation

@yuzawa-san

Copy link
Copy Markdown
Owner
  • add new types, add support for existing types
  • try to provide relevant buffer views based on type sizes

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.16%. Comparing base (a7ddbb1) to head (6268cab).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...n/java/com/jyuzawa/onnxruntime/TensorInfoImpl.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #421      +/-   ##
============================================
+ Coverage     94.15%   94.16%   +0.01%     
  Complexity      503      503              
============================================
  Files            38       38              
  Lines          1608     1611       +3     
  Branches        121      121              
============================================
+ Hits           1514     1517       +3     
  Misses           70       70              
  Partials         24       24              
Flag Coverage Δ
java-25-macos-latest 93.85% <97.36%> (+0.01%) ⬆️
java-25-ubuntu-latest 93.35% <97.36%> (+0.01%) ⬆️
java-25-windows-latest 93.35% <97.36%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nk2IsHere nk2IsHere left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great! Thank you!

As per float16 being treated as float array in onnx java implementation instead: https://github.com/microsoft/onnxruntime/blob/e8b9b24a31ed791d8cdfc515b2b5dfe46db9d6a6/java/src/main/java/ai/onnxruntime/TensorInfo.java#L341-L344

From our experience we also used float array to represent float16 tensors. If it is to be used with short array as a backing, its would be good to run a small identity model on them to confirm this is what onnx allows to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants