docs(contributing): fix the dead labels.yml link on main#804
Merged
Conversation
main links to z-shell/.github/.github/lib/labels.yml, which became a 404 when that duplicate was removed in z-shell/.github#471. The corrected link already exists on next via #802, but main requires branches to be up to date and its required Trunk Check fails on this 404, so the promotion that would carry the fix is blocked by the fix's absence. Applies the same one-line correction directly to main to break that deadlock. Identical to the change already on next, so the branches converge cleanly.
Deploying zsh with
|
| Latest commit: |
652b49e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://86aa1965.zsh.pages.dev |
| Branch Preview URL: | https://fix-labels-link-on-main.zsh.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the contributing documentation to point to the canonical labels.yml location in z-shell/.github, fixing a dead link on main that blocks link-checking (lychee) and therefore the next → main promotion flow.
Changes:
- Replaces the outdated
/.github/lib/labels.ymlURL with the correct/lib/labels.ymlURL in the Labels section of the contributing docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line fix to unblock #803.
The deadlock
mainlinks tohttps://github.com/z-shell/.github/blob/main/.github/lib/labels.yml, which became a 404 when that duplicate file was removed in z-shell/.github#471.The corrected link is already on
next(#802). But:mainrequires theTrunk Checkcontext, with strict mode (branches must be up to date)Trunk Checkruns lychee againstmain's content and fails on that 404The fix
The same one-line correction, applied directly to
main. Identical to what is already onnext, so the two converge with no conflict and #803 can then proceed.The new target resolves (
HTTP 200); the old one is intentionally gone.