Skip to content

Chore: AI 오케스트레이션 세팅 #46

Merged
zaewc merged 15 commits into
developfrom
chore/n8n
May 20, 2026
Merged

Chore: AI 오케스트레이션 세팅 #46
zaewc merged 15 commits into
developfrom
chore/n8n

Conversation

@zaewc
Copy link
Copy Markdown
Owner

@zaewc zaewc commented May 20, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces documentation for an AI-assisted development pipeline and a corresponding prompt template for the repository. The feedback provided addresses a non-standard glob pattern for test files and a conflict in the verification steps where the --frozen-lockfile flag would prevent necessary lockfile updates when dependencies are modified.

5. Do not change the public API (exported names, type signatures, default exports)
unless the issue explicitly requires it. If you must, call it out in the PR body.
6. When behavior changes, add or update tests in the same package
(`packages/<pkg>/src/**/*.test.ts(x)` or the package's existing test layout).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

테스트 파일 경로 패턴에서 ts(x)는 표준적인 글로브(glob) 패턴이 아닙니다. AI가 정확하게 파일을 찾을 수 있도록 {ts,tsx} 또는 ts*와 같은 표준 형식을 사용하는 것이 좋습니다.

Suggested change
(`packages/<pkg>/src/**/*.test.ts(x)` or the package's existing test layout).
(packages/<pkg>/src/**/*.test.{ts,tsx} or the package's existing test layout).

Comment thread docs/ai-dev-prompt-template.md Outdated
@zaewc zaewc self-assigned this May 20, 2026
@zaewc
Copy link
Copy Markdown
Owner Author

zaewc commented May 20, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces documentation for an AI-assisted development pipeline, including a prompt template and a detailed architectural overview involving n8n and GitHub Actions. The feedback focuses on refining security wildcard patterns to avoid over-blocking files, updating the installation command to allow lockfile updates when dependencies change, ensuring branch naming consistency, and synchronizing security rules across the documentation files.

Comment thread docs/ai-dev-prompt-template.md Outdated
Comment thread docs/ai-dev-prompt-template.md Outdated
Comment thread docs/ai-pipeline.md
Comment thread docs/ai-pipeline.md Outdated
@github-actions
Copy link
Copy Markdown

📊 Test Coverage Report (vitest)

Package Statements Branches Functions Lines
@scrolloop/core 293/293 (100%) 75/76 (98.68%) 30/30 (100%) 293/293 (100%)
@scrolloop/react 420/715 (58.74%) 73/89 (82.02%) 5/17 (29.41%) 420/715 (58.74%)
@scrolloop/react-native 0/238 (0%) 1/4 (25%) 1/4 (25%) 0/238 (0%)
@scrolloop/shared 176/176 (100%) 54/54 (100%) 14/14 (100%) 176/176 (100%)

@zaewc
Copy link
Copy Markdown
Owner Author

zaewc commented May 20, 2026

/gemini review

@github-actions
Copy link
Copy Markdown

📊 Test Coverage Report (vitest)

Package Statements Branches Functions Lines
@scrolloop/core 293/293 (100%) 75/76 (98.68%) 30/30 (100%) 293/293 (100%)
@scrolloop/react 420/715 (58.74%) 73/89 (82.02%) 5/17 (29.41%) 420/715 (58.74%)
@scrolloop/react-native 0/238 (0%) 1/4 (25%) 1/4 (25%) 0/238 (0%)
@scrolloop/shared 176/176 (100%) 54/54 (100%) 14/14 (100%) 176/176 (100%)

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces documentation for the AI-assisted development pipeline, including a reusable prompt template and a detailed architecture overview for n8n and GitHub Actions integration. The review feedback suggests adding 'area:shared' to the label list in the pipeline documentation for consistency and updating the 'pnpm install' command in the prompt template to use '--frozen-lockfile' by default to prevent unintended lockfile changes.

Comment thread docs/ai-pipeline.md
Comment thread docs/ai-dev-prompt-template.md Outdated
zaewc and others added 2 commits May 20, 2026 19:40
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

📊 Test Coverage Report (vitest)

Package Statements Branches Functions Lines
@scrolloop/core 293/293 (100%) 75/76 (98.68%) 30/30 (100%) 293/293 (100%)
@scrolloop/react 420/715 (58.74%) 73/89 (82.02%) 5/17 (29.41%) 420/715 (58.74%)
@scrolloop/react-native 0/238 (0%) 1/4 (25%) 1/4 (25%) 0/238 (0%)
@scrolloop/shared 176/176 (100%) 54/54 (100%) 14/14 (100%) 176/176 (100%)

@github-actions
Copy link
Copy Markdown

📊 Test Coverage Report (vitest)

Package Statements Branches Functions Lines
@scrolloop/core 293/293 (100%) 75/76 (98.68%) 30/30 (100%) 293/293 (100%)
@scrolloop/react 420/715 (58.74%) 73/89 (82.02%) 5/17 (29.41%) 420/715 (58.74%)
@scrolloop/react-native 0/238 (0%) 1/4 (25%) 1/4 (25%) 0/238 (0%)
@scrolloop/shared 176/176 (100%) 54/54 (100%) 14/14 (100%) 176/176 (100%)

@zaewc zaewc merged commit b8901cb into develop May 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant