Conversation
|
Thanks for the contribution! This PR changes files that are maintained by the ZCode team and cannot be taken from external contributions: 🤖 Copy this prompt into Claude Code / Codex to fix it |
f84e4c2 to
f09c94b
Compare
|
Thanks! I removed |
|
✅ Internal validation passed. A ZCode maintainer will review the change next; once merged it is published to the marketplace and this PR is closed automatically. |
|
Thanks for the fix! One thing worth calling out: this PR introduces a new runtime dependency on Before this change, the three hooks and the
The README currently says "ZCode 自带的 Node.js 负责启动这个解析器", but ZCode does not expose a bundled Node binary to third-party plugins. The desktop app runs its own agent on Electron's Node ( This matters especially for the Windows users from #14: a machine with Python installed but no Node.js will now fail with " Suggestion: please update the README to
It would also help to mention this in the PR description so reviewers know the fix for #14 assumes Node.js is available. |
f09c94b to
1aa797b
Compare
|
Thanks for catching this. I updated |
1aa797b to
9693c93
Compare
|
✅ Internal validation passed. A ZCode maintainer will review the change next; once merged it is published to the marketplace and this PR is closed automatically. |
|
✅ Internal validation passed. A ZCode maintainer will review the change next; once merged it is published to the marketplace and this PR is closed automatically. |
0.10.0 ships the jev_classify fallback-id collision and null-prototype tally fixes (zai-org#36), plus the jev_verify none-id fix (zai-org#38). Pinning 0.9.0 would ship the classify bugs this plugin's skill teaches agents to rely on.
Summary
On Windows, the official Python installer exposes
python.exeand thepylauncher but does not provide apython3command. Thevideo-agent-kithooks therefore failed on every SessionStart, UserPromptSubmit, and Stop event for the environment reported in #14. The MCP stdio entrypoint had the same platform assumption.This change:
py -3/pythonon Windows andpython3/pythonon macOS and Linux;video-editMCP server through that launcher;PATHin addition to Python 3.10+; ZCode does not expose a bundled Node binary to third-party plugins;0.4.5in both manifests and the marketplace.Fixes #14
Validation
python scripts/validate.py— 26 plugins validated.python scripts/build_dist.py— passed;video-agent-kit/0.4.5/plugin.zipcontains the launcher and updated entrypoints.git diff --check— passed.node --check plugins/video-agent-kit/hooks/run_python.mjs— passed.7— returned7unchanged.The launcher was tested directly; a full ZCode desktop session was not available in this environment.