Fix implicitly nullable parameter declarations deprecated #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hm, am I mistaken, or is it precisely your change that is causing the warning you want to fix - again, before your commit this issue was gone? Since version 8.2, PHP requires nullable to be specified as a type, so |
Contributor
Author
Well apparently not anymore now with php 8.5, since it's deprecated in 8.4. |
Contributor
Author
|
Or.. Homelab wait I'm very confused now. Should we revert this commit.? |
|
I think so, yes, you do revert the fix from #66 :/ |
melroy89
added a commit
to melroy89/zammad-api-client-php
that referenced
this pull request
Dec 20, 2025
mgruner
pushed a commit
that referenced
this pull request
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
?$var = nullshould not be used anymore, and will show deprecation warnings.See: https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated
Fixes: #69