Skip to content

fix: Enabled "follow focus" opens in Chrome 57.0.2987.133 the Chrome Help too #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
webbrain-one wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Enabled "follow focus" opens in Chrome 57.0.2987.133 the Chrome Help too #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...rc/main/java/org/vaadin/jonatan/contexthelp/widgetset/client/ui/ContextHelpConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
package org.vaadin.jonatan.contexthelp.widgetset.client.ui;

import com.google.gwt.event.dom.client.KeyDownEvent;
import com.google.gwt.event.dom.client.KeyDownHandler;

import com.google.gwt.core.client.Scheduler;
import com.google.gwt.core.client.Scheduler.ScheduledCommand;
import com.vaadin.client.ServerConnector;
Expand Down Expand Up @@ -30,6 +33,17 @@ protected void extend(ServerConnector serverConnector) {
contextHelp.setHelpKeyCode(getState().helpKey);
contextHelp.setHideOnBlur(getState().hideOnBlur);
}
if (getState().followFocus) {
serverConnector.getWidget().addKeyDownHandler(new KeyDownHandler() {
@Override
public void onKeyDown(KeyDownEvent event) {
if (event.getKeyCode() == ShortcutAction.KeyCode.F1) {
event.preventDefault();
event.stopPropagation();
}
}
});
}
}

@Override
Expand Down