fix: write rollout links to job summary; drop employee address column - #10
Merged
Conversation
bytebase-action rollout writes Release/Plan/Rollout links and a stage status table to the file named by GITHUB_STEP_SUMMARY, but the raw docker run never received that variable or the file, so the write failed silently and the run summary stayed empty. Mount the runner's step summary file into the container and pass GITHUB_STEP_SUMMARY. Also pass GITHUB_SERVER_URL, GITHUB_REPOSITORY and GITHUB_SHA so the Bytebase release links back to the GitHub commit instead of the broken '//commit/' URL. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Follow-up migration that reverts 2026090701_add_employee_address.sql. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
SQL Review Summary
Detailed Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bytebase-action rolloutwrites them to the file named byGITHUB_STEP_SUMMARY. Because the action runs through a rawdocker run, that variable and file never reached the container, so the write failed silently and the summary stayed empty. Each rollout step now mounts the runner's summary file and passes the variable.GITHUB_SERVER_URL,GITHUB_REPOSITORYandGITHUB_SHAare passed so the release's VCS source URL is no longer the broken//commit/.2026090702_drop_employee_address.sqldrops theaddresscolumn added by2026090701_add_employee_address.sql.Verification
create-rollout,deploy-to-testanddeploy-to-prodshould show Release/Plan/Rollout links and a stage table on the run's Summary page, and the release in Bytebase should link to the merge commit.🤖 Generated with Claude Code