Skip to content

Fix Lua language server startup when offline - #65

Open
cmdr-chara wants to merge 2 commits into
zed-extensions:mainfrom
cmdr-chara:cmdr-chara/fix-lua-offline-lsp-9789
Open

Fix Lua language server startup when offline#65
cmdr-chara wants to merge 2 commits into
zed-extensions:mainfrom
cmdr-chara:cmdr-chara/fix-lua-offline-lsp-9789

Conversation

@cmdr-chara

@cmdr-chara cmdr-chara commented Sep 8, 2026

Copy link
Copy Markdown

Summary

I used AI assistance to develop this fix, reviewed the changes, and tested it offline on Linux.

  • Resolve an explicit or PATH-provided server without eagerly invoking managed installation.
  • Fall back to the newest complete stable LuaLS installation on disk when the update request fails after restarting Zed.
  • Stage downloads before promotion so failed extraction does not expose an incomplete cached installation.

Addresses the Lua-specific case of zed-industries/zed#9789; does not resolve the broader issue. Cold startup still waits for the update request to fail before falling back.

Verification

  • 15 standalone Rust tests pass, compiling the actual binary-resolution module with warnings denied.
  • Rust formatting and whitespace checks pass.
  • I installed the development extension in Zed on Linux and confirmed that completions and documentation worked after restarting offline, as shown in the screenshot below.
  • Full cross-platform validation remains outstanding; Windows filenames were tested on Linux, not on Windows. No Zed rebuild was performed.

Screenshot

image

Tested on Linux: fully quit Zed, disconnected from the internet, and reopened the Lua file. Completions and documentation worked after the update request timed out.

Release Notes:

  • Fixed Lua language server startup when offline and a previously downloaded server is available.

@cla-bot cla-bot Bot added the cla-signed label Sep 8, 2026
@cmdr-chara
cmdr-chara marked this pull request as ready for review September 8, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant