Remove obsolete workflows, optimize codebase#6
Merged
Conversation
new_release.yml and publish.yml used `import toml` (not installed), referenced old non-workspace paths, and had a confusing auto-bump version feature. Publishing is now handled by the per-package publish-zeeker.yml and publish-common.yml workflows. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Production code: - Fix bare except clauses in sources_page.py - Fix malformed version string in manage.py - Add sync_retry to zeeker-common exports - Fix hash collision bug (use null byte separator instead of pipe) - Consolidate duplicate S3 upload logic in deployer.py - Deduplicate cache key generation in async_executor.py - Pass pre-loaded module from builder to processor (avoid double load) - Extract common CLI helpers: require_project, require_database, create_deployer, load_env — eliminating ~80 lines of boilerplate - Remove legacy deprecated generate command - Merge 4 .j2 templates into 1 unified resource_template.py.j2 - Merge 4 fallback generator methods into 1 in templates.py Tests: - Delete duplicate test_deployer_integration.py (-20 tests) - Remove framework/trivial tests (dotenv, CLI help, Click) - Consolidate zeeker-common test boilerplate with fixtures - Remove trivial config tests - Add command layer tests (helpers, metadata, backup, assets) Result: 369 → 350 tests, 68.95% → 75.79% coverage Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
houfu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workflow cleanup
new_release.ymlandpublish.yml— usedimport toml(not installed), referenced pre-workspace paths, had confusing auto-bump version. Publishing handled bypublish-zeeker.ymlandpublish-common.yml.Production code optimization
except:clauses in sources_page.pysync_retryexport to zeeker-commonrequire_project,require_database,create_deployer,load_env) — ~80 lines of duplication removedgeneratecommandresource_template.py.j2(-470 lines)Test optimization
test_deployer_integration.py(-20 tests)Results
Test plan
🤖 Generated with Claude Code