Repository navigation
fix: derive unexpected inequality from equality - #37
Merged
Merged
Conversation
Use wrapper equality and its exception specification in C++17, and rely on rewritten comparisons in C++20 and later. This supports equality-only error types and propagates exceptions from equality or bool conversion. Wrapper inequality now follows the negation of wrapper equality even when the error type defines != independently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #36, addressing the same
noexceptissue inunexpected::operator!=: the implicit conversion of the comparison result toboolis not accounted for.Use wrapper equality and its exception specification in C++17, and rely on rewritten comparisons in C++20 and later. This reuses the corrected
operator==from #36, supports equality-only error types, and makes wrapper inequality negate wrapper equality even when the error type defines!=independently.