Skip to content

feat: API for delegating credentials to generate a z/OS PassTicket #4368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Goutham024 wants to merge 5 commits into
base: v3.x.x
Choose a base branch
from
Open

feat: API for delegating credentials to generate a z/OS PassTicket #4368

Goutham024 wants to merge 5 commits into from
+244 −4

Conversation

@Goutham024
Copy link

@Goutham024 Goutham024 commented Oct 30, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Linked to #4365
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@Goutham024 Goutham024 marked this pull request as draft October 30, 2025 05:10
@Goutham024 Goutham024 mentioned this pull request Oct 30, 2025
Open
10 tasks
@Goutham024 Goutham024 changed the title API for delegating credentials to generate a z/OS PassTicket feat: API for delegating credentials to generate a z/OS PassTicket Oct 30, 2025
@Goutham024
Copy link
Author

Goutham024 commented Oct 30, 2025

OLD PR: #4364
In the above PR I encountered multiple merge conflicts while rebasing for the DCO fix, as the branch was behind 155 commits with v3.x.x. After trying to sync with the latest changes, the conflicts became quite extensive and time-consuming to resolve. To simplify the process, I’ve created a this PR instead. Please review the PR.

@havenkat
Copy link

havenkat commented Oct 30, 2025

@balhar-jakub @pablocarle there was some issue with the previous pr for signing, hence created this new one. we will discuss in this pr.
CC: @Joe-Winchester

@EvaJavornicka EvaJavornicka moved this from New to In Progress in API Mediation Layer Backlog Management Nov 5, 2025
@Goutham024 Goutham024 marked this pull request as ready for review November 6, 2025 05:40
@havenkat
Copy link

havenkat commented Nov 6, 2025

@pablocarle @balhar-jakub PR is ready for review

@Goutham024 Goutham024 force-pushed the passticket-delegation-api branch from 8d9766d to aae08aa Compare December 30, 2025 11:28
@Goutham024 Goutham024 closed this Dec 30, 2025
@Goutham024 Goutham024 force-pushed the passticket-delegation-api branch from aae08aa to 2a26ebb Compare December 30, 2025 11:39
@Goutham024 Goutham024 reopened this Dec 30, 2025
@Goutham024
API for delegating credentials to generate a z/OS PassTicket
1ace669 
Signed-off-by: Gowtham Selvaraj <Gowtham.Selvaraj1@ibm.com>
@Goutham024 Goutham024 force-pushed the passticket-delegation-api branch from 931fc9b to 1ace669 Compare December 30, 2025 11:47
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Jan 5, 2026
@Goutham024 Goutham024 force-pushed the passticket-delegation-api branch from 44ba182 to 36654ae Compare January 5, 2026 06:52
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Jan 5, 2026
havenkat
havenkat reviewed Jan 5, 2026
View reviewed changes
zaas-service/src/main/java/org/zowe/apiml/zaas/controllers/StsController.java Outdated
Comment on lines 55 to 56
@SecurityRequirement(name = "Bearer"),
@SecurityRequirement(name = "LoginBasicAuth"),
Copy link

@havenkat havenkat Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This api is supported only for client certificate. we should remove the bearer and basic options.

zaas-service/src/main/java/org/zowe/apiml/zaas/controllers/StsController.java Outdated
if (response.getRc() == 0 && StringUtils.isNotEmpty(response.getUserId())) {
zosUserId = response.getUserId();
}
log.info("Getting ZOS_User_id: {} ", zosUserId);
Copy link

@havenkat havenkat Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

" Got ZOS_User_id

zaas-service/src/main/java/org/zowe/apiml/zaas/controllers/StsController.java Outdated
}
log.info("Getting ZOS_User_id: {} ", zosUserId);
var ticket = passTicketService.generate(zosUserId, applID);
log.info("Getting request email id: {} and ZOS_Userid: {}", emailID, zosUserId);
Copy link

@havenkat havenkat Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User emailD : {} and ZOS_User_id : {}

havenkat
havenkat reviewed Jan 6, 2026
View reviewed changes
gateway-service/src/main/java/org/zowe/apiml/gateway/config/WebSecurity.java
}

}
}
Copy link

@havenkat havenkat Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NO change in this file, we should not checkin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@havenkat havenkat havenkat left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

size/L

Projects

API Mediation Layer Backlog Management
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Goutham024 @havenkat