Skip to content

chore: Include testing of Node.JS and Python enabler sample apps and enhance NodeJS enabler to read p12 #4430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
taban03 merged 150 commits into from
Jan 2, 2026
Merged

chore: Include testing of Node.JS and Python enabler sample apps and enhance NodeJS enabler to read p12 #4430

taban03 merged 150 commits into from
Jan 2, 2026

Conversation

@taban03
Copy link
Contributor

@taban03 taban03 commented Dec 15, 2025 •
edited
Loading

Description

A bug for the Node Enabler has been recently introduced and we were not able to discover it until now, since we are not testing the enablers applications as part of our CI/CD.
This PR includes:

  • Enhance the nodejs enabler to support both PKCS12 + old legacy format (key + certificate)
  • Creation of integration test for the Python and Node sample app
  • Include deployment and run of the tests for Node.JS and Python Onboarding enablers as part of the GH pipeline.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@taban03 taban03 marked this pull request as draft December 15, 2025 10:20
@taban03 taban03 changed the title chore: Include testing of Node.JS and Python enabler sample apps fix: Fix Node.JS Enabler and include testing of Node.JS and Python enabler sample apps Dec 16, 2025
@taban03 taban03 changed the title fix: Fix Node.JS Enabler and include testing of Node.JS and Python enabler sample apps chore: Fix Node.JS Enabler and include testing of Node.JS and Python enabler sample apps Dec 17, 2025
@taban03 taban03 changed the title chore: Fix Node.JS Enabler and include testing of Node.JS and Python enabler sample apps chore: Include testing of Node.JS and Python enabler sample apps Dec 17, 2025
@EvaJavornicka EvaJavornicka moved this from New to In Progress in API Mediation Layer Backlog Management Dec 17, 2025
@taban03 taban03 force-pushed the reboot/run_nodejs_and_python_services branch from 9995553 to deb9446 Compare December 18, 2025 13:49
taban03 added 19 commits December 19, 2025 15:19
@taban03
add testing for nodejs and python services
cd0886c 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
fix path
5049704 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
fix path
742cb00 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
attempt
6d48d35 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
try to fix npm step
1564e43 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
try to fix npm step
7adbc22 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
install dep for onboarding enabler node
4ba4938 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
add pem
d0e4b25 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
add keystore in correct format
328068d 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
point to the correct keystore
34e5386 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
attempt
0e286ed 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
fix config for python and run on background
931284f 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
fix cd path
1dd2a06 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
setup python
e5f95db 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
fix path
84c377d 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
use bash
9bd106c 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
fix pipenv
cb4a12a 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
change python version
8c4b13d 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
fix nodejs enabler
2846ba7 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>

# Conflicts:
#	onboarding-enabler-nodejs/src/index.js
taban03 and others added 12 commits December 31, 2025 15:51
@taban03
attempt
3f6879b 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
fix
478bf4d 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
fix path
5be7fcc 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
fix path
259d67c 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
fix configuration
26e91fe 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
fix
6336f48 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
avoid hardcode
bda1b32 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
fix endpoint
2523523 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
Merge branch 'v3.x.x' into reboot/run_nodejs_and_python_services
2d5e401
@taban03
fix content type
bb7b0e0 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
fix content type
740d09e 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
revert back changes and add the await to the tests
e390029 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
taban03 added 2 commits January 2, 2026 11:57
@taban03
remove unused var
22bb8ba 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
fix revert
7157080 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03 taban03 marked this pull request as ready for review January 2, 2026 11:23
achmelo
achmelo reviewed Jan 2, 2026
View reviewed changes
taban03 added 2 commits January 2, 2026 16:00
@taban03
Support both p12 and key+cert in the node enabler
c9a67e3 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
address pr comments
c3c2a61 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
update readme
c347a23 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03 taban03 changed the title chore: Include testing of Node.JS and Python enabler sample apps chore: Include testing of Node.JS and Python enabler sample apps and enhance NodeJS enabled to read p12 Jan 2, 2026
@taban03 taban03 changed the title chore: Include testing of Node.JS and Python enabler sample apps and enhance NodeJS enabled to read p12 chore: Include testing of Node.JS and Python enabler sample apps and enhance NodeJS enabler to read p12 Jan 2, 2026
taban03 added 2 commits January 2, 2026 18:06
@taban03
exclude python tests from the container suite
901b247 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
exclude node and python from other suites
20e1831 
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 2, 2026

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@taban03 taban03 merged commit d3bd9f4 into v3.x.x Jan 2, 2026
40 of 41 checks passed
@taban03 taban03 deleted the reboot/run_nodejs_and_python_services branch January 2, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achmelo achmelo achmelo approved these changes

Assignees

No one assigned

Labels

size/XL

Projects

API Mediation Layer Backlog Management
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@taban03 @achmelo @richard-salac