Closed
Conversation
Author
|
Tests are still pending. I want to create a realistic test suite and running it in PhantomJS using the mocha wrapper (see Makefile). Additionally it should run also in SauceLabs, Testling or BrowserStack in order to guarantee the cross-browser support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this PR is still a work in progress, since there's a lot of improvements, features and API changes that requires a deep test coverage. This PR is oriented to a next library version release (
0.1.0)I made several major improvements/refactors, follow better conventions and adding support for some nice-to-have features, detailed below:
IMPORTANT: note that there's still required some refactors and better code design and clean API, but the existent code and features are an initial good point to start with