Skip to content

feat(#465): remove PowerShell source analysis and leftover contract fields - #467

Merged
2233admin merged 3 commits into
mainfrom
feat/465-drop-powershell-analysis
Oct 19, 2026
Merged

2233admin merged 3 commits into
mainfrom
feat/465-drop-powershell-analysis

Conversation

@2233admin

Copy link
Copy Markdown
Owner

Part of #465 (owner decision: cut PowerShell entirely, including analysis of .ps1 in scanned repos). Merges before the docs PR #466.

  • Removed PowerShell language detection, symbol extraction, dot-source/Import-Module edges, signature parsing and PowerShell-specific complexity rules (graph, native_code_evidence, sentrux_analysis, sentrux_gate, extension lists). .ps1 in a scanned repo is now unsupported/plain text; language parsing belongs to CodeGraph.
  • Contracts: dropped powershell from the native-code-evidence languages and internalization fixtures, the required powershell version from the clean-machine verifier attestation, and the orphaned model-executable-handle schema. Pins re-synced with repin --repo . --write.
  • Kept the guards that keep PowerShell out (no tracked .ps1, manifest names no PowerShell, install smoke without pwsh, powershell.exe hardcoded-path hit).

Local: full cargo test -p code-intel passes except the known root-only walk_code_files_keeps_readable_siblings_when_directory_is_unreadable; self-scan closure --require-pass passes; repin clean; hardcoded-path lint OK.


Generated by Claude Code

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T11:02:19.779849Z c43215f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Code Intel change risk

Score Percentile Level
69/100 89th (vs last 47 commits) 🟡 medium

Top signals

  • Diff shape: 37 file(s), +133/-544 (max file share 0.35)
  • Test asymmetry: source changed, tests touched
  • Bug-magnet: 203 fix commit(s) in touched files (180d)
  • Churn: 478 commit(s) touching these files (90d)

revspec: origin/main..HEAD · threshold: score >= 80 blocks unless labeled risk-accepted; percentile is reported, not gated (#201) · code-intel change risk

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Code Intel Quality Signal

Completeness: complete · snapshot f394ff7b3357 · commit ad49193c338a
Admission: pass · policy evidence-quality-admission v1 · aggregate regression: not_declined (advisory, not a blocking gate)

Total Baseline Delta
6750 6631 [OK] 119

Bottleneck: depth

Root cause Baseline Current Delta
modularity 0.29 n/a
acyclicity 0.0 n/a
depth 8.0 n/a
equality 0.47 n/a
redundancy 0.0 n/a

Findings (1 total)

Kind Severity Disposition Rule Message
root_cause_diagnostic medium advisory depth Quality Signal bottleneck: depth

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c43215f21d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

pub(crate) const CODE_EXTENSIONS: &[&str] = &[
"ps1", "psm1", "py", "rs", "go", "ts", "tsx", "js", "jsx", "mjs", "cjs", "java", "cs", "cpp",
"c", "h", "hpp", "v",
"py", "rs", "go", "ts", "tsx", "js", "jsx", "mjs", "cjs", "java", "cs", "cpp", "c", "h", "hpp",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Version the baseline after dropping source extensions

When a target repository has an existing v6/engine-3.0.0 baseline created while .ps1 and .psm1 files were included, this change measures a different file set but leaves BASELINE_SCHEMA and ENGINE_VERSION unchanged. valid_baseline therefore accepts incomparable metrics, producing fabricated quality deltas and treating formerly measured PowerShell god files as resolved instead of returning baseline_engine_mismatch; bump the baseline identity and require an intentional re-baseline.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not bumping in this PR. A version bump makes every existing baseline fail with baseline_engine_mismatch, including this repository's own owner-approved .sentrux/baseline.json (whose metrics don't change: this repo has no .ps1). The affected case is a target repository that kept .ps1 files and an old baseline; that is put to the owner to decide.


Generated by Claude Code

Comment thread orchestration/internalization/c03-r05-r12-measurements.json
Comment thread orchestration/internalization/pon-multilanguage.json
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 37 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fe6dbca7-249a-4950-a397-2985a2ed4308
📥 Commits

Reviewing files that changed from the base of the PR and between 5e239c5 and 9f9368f.

📒 Files selected for processing: 37
  • crates/code-intel-cli/src/codegraph_provider/mod.rs
  • crates/code-intel-cli/src/codenexus_lite.rs
  • crates/code-intel-cli/src/file_gate/rules.rs
  • crates/code-intel-cli/src/graph/mod.rs
  • crates/code-intel-cli/src/language_pref/mod.rs
  • crates/code-intel-cli/src/native_code_evidence.rs
  • crates/code-intel-cli/src/project_orientation.rs
  • crates/code-intel-cli/src/project_orientation_benchmark.rs
  • crates/code-intel-cli/src/sentrux_analysis.rs
  • crates/code-intel-cli/src/sentrux_gate.rs
  • crates/code-intel-cli/src/workflow_recommendation.rs
  • crates/code-intel-cli/tests/capability_exec.rs
  • crates/code-intel-cli/tests/internalization_record.rs
  • crates/code-intel-cli/tests/native_code_evidence.rs
  • crates/code-intel-cli/tests/project_orientation_benchmark.rs
  • crates/code-intel-cli/tests/sentrux_analysis.rs
  • crates/code-intel-cli/tests/understanding_quadrant.rs
  • docs/language-adapter-acceptance-standard.md
  • docs/tool-effectiveness-baseline.md
  • orchestration/acceptance/native-code-evidence-candidate.json
  • orchestration/evidence/d02-clean-machine-verifier-attestation.v1.json
  • orchestration/integrations.json
  • orchestration/internalization/ast-grep.json
  • orchestration/internalization/bmad.json
  • orchestration/internalization/c03-r05-r12-measurements.json
  • orchestration/internalization/codegraph.json
  • orchestration/internalization/codenexus.json
  • orchestration/internalization/fixtures/pon-multilanguage-code-evidence.json
  • orchestration/internalization/fixtures/r06-native-labeled-corpus.json
  • orchestration/internalization/git.json
  • orchestration/internalization/graph.json
  • orchestration/internalization/native-code-evidence.json
  • orchestration/internalization/pon-multilanguage.json
  • orchestration/internalization/rg.json
  • orchestration/internalization/sentrux.json
  • orchestration/schemas/code-intel-clean-machine-verifier-attestation.v1.schema.json
  • orchestration/schemas/code-intel-model-executable-handle.v1.schema.json
✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@2233admin
2233admin merged commit f6c07f2 into main Oct 19, 2026
18 checks passed
2233admin pushed a commit that referenced this pull request Oct 19, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018bnC1Tos5MvBbFEj5zzi51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants