Repository navigation
feat(#465): remove PowerShell source analysis and leftover contract fields - #467
Conversation
…ields Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018bnC1Tos5MvBbFEj5zzi51
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Code Intel change risk
Top signals
revspec: |
Code Intel Quality SignalCompleteness: complete · snapshot
Bottleneck: depth
Findings (1 total)
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c43215f21d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub(crate) const CODE_EXTENSIONS: &[&str] = &[ | ||
| "ps1", "psm1", "py", "rs", "go", "ts", "tsx", "js", "jsx", "mjs", "cjs", "java", "cs", "cpp", | ||
| "c", "h", "hpp", "v", | ||
| "py", "rs", "go", "ts", "tsx", "js", "jsx", "mjs", "cjs", "java", "cs", "cpp", "c", "h", "hpp", |
There was a problem hiding this comment.
Version the baseline after dropping source extensions
When a target repository has an existing v6/engine-3.0.0 baseline created while .ps1 and .psm1 files were included, this change measures a different file set but leaves BASELINE_SCHEMA and ENGINE_VERSION unchanged. valid_baseline therefore accepts incomparable metrics, producing fabricated quality deltas and treating formerly measured PowerShell god files as resolved instead of returning baseline_engine_mismatch; bump the baseline identity and require an intentional re-baseline.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Not bumping in this PR. A version bump makes every existing baseline fail with baseline_engine_mismatch, including this repository's own owner-approved .sentrux/baseline.json (whose metrics don't change: this repo has no .ps1). The affected case is a target repository that kept .ps1 files and an old baseline; that is put to the owner to decide.
Generated by Claude Code
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 37 minutes. View limit details
✨ Finishing Touches: 💡 1
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018bnC1Tos5MvBbFEj5zzi51
… counts Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018bnC1Tos5MvBbFEj5zzi51
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018bnC1Tos5MvBbFEj5zzi51
Part of #465 (owner decision: cut PowerShell entirely, including analysis of
.ps1in scanned repos). Merges before the docs PR #466.Import-Moduleedges, signature parsing and PowerShell-specific complexity rules (graph,native_code_evidence,sentrux_analysis,sentrux_gate, extension lists)..ps1in a scanned repo is now unsupported/plain text; language parsing belongs to CodeGraph.powershellfrom the native-code-evidence languages and internalization fixtures, the requiredpowershellversion from the clean-machine verifier attestation, and the orphaned model-executable-handle schema. Pins re-synced withrepin --repo . --write..ps1, manifest names no PowerShell, install smoke without pwsh,powershell.exehardcoded-path hit).Local: full
cargo test -p code-intelpasses except the known root-onlywalk_code_files_keeps_readable_siblings_when_directory_is_unreadable; self-scan closure--require-passpasses; repin clean; hardcoded-path lint OK.Generated by Claude Code