fix: WSL TrueForge launch - #13
Merged
Merged
Conversation
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
added
the
size:S
PR Summary by QodoFix TrueForge startup through a temporary WSL script
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
|
Failed to generate code suggestions for PR |
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| #!/bin/bash | ||
| export PATH=/usr/bin:/usr/local/bin:/usr/local/sbin:/usr/sbin:/sbin:$PATH | ||
| cd ~ | ||
| npx @truefoundry/trueforge |
There was a problem hiding this comment.
Suggestion: The launcher omits npx -y, unlike the repository-supported TrueForge launcher. Because the package was installed globally but is not necessarily resolved by npx as an executable package, npx can prompt for confirmation to install it in the new terminal, causing the one-click startup to wait instead of launching unattended. [api mismatch]
Severity Level: Major ⚠️
- ❌ One-click TrueForge startup can block on an interactive npx prompt.
- ⚠️ The WSL terminal requires manual confirmation before serving TrueForge.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** start.ps1
**Line:** 89:89
**Comment:**
*Api Mismatch: The launcher omits `npx -y`, unlike the repository-supported TrueForge launcher. Because the package was installed globally but is not necessarily resolved by `npx` as an executable package, `npx` can prompt for confirmation to install it in the new terminal, causing the one-click startup to wait instead of launching unattended.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix| '@ | ||
| $scriptPath = "$env:TEMP\start-tf.sh" | ||
| [System.IO.File]::WriteAllText($scriptPath, $wslScript, [System.Text.UTF8Encoding]::new($false)) | ||
| Start-Process wsl -ArgumentList "-d Ubuntu -- bash -c 'bash /mnt/c/$($env:TEMP -replace '\\','/')/start-tf.sh'" |
There was a problem hiding this comment.
Suggestion: The constructed WSL path is invalid for the normal Windows TEMP value, which includes the drive prefix, such as C:\Users\...\AppData\Local\Temp. This produces /mnt/c/C:/Users/.../start-tf.sh, so WSL cannot find the generated script. Convert the Windows path with wslpath or strip the drive prefix and map the actual drive before launching. [logic error]
Severity Level: Major ⚠️
- ❌ TrueForge fails to launch from the one-click Windows startup script.
- ⚠️ The dashboard starts while its required TrueForge terminal remains unavailable.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** start.ps1
**Line:** 93:93
**Comment:**
*Logic Error: The constructed WSL path is invalid for the normal Windows `TEMP` value, which includes the drive prefix, such as `C:\Users\...\AppData\Local\Temp`. This produces `/mnt/c/C:/Users/.../start-tf.sh`, so WSL cannot find the generated script. Convert the Windows path with `wslpath` or strip the drive prefix and map the actual drive before launching.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
Code Review by Qodo
1. Invalid WSL temp path
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| '@ | ||
| $scriptPath = "$env:TEMP\start-tf.sh" | ||
| [System.IO.File]::WriteAllText($scriptPath, $wslScript, [System.Text.UTF8Encoding]::new($false)) | ||
| Start-Process wsl -ArgumentList "-d Ubuntu -- bash -c 'bash /mnt/c/$($env:TEMP -replace '\\','/')/start-tf.sh'" |
There was a problem hiding this comment.
1. Invalid wsl temp path 🐞 Bug ≡ Correctness
The launcher prepends /mnt/c/ to the complete Windows %TEMP% value, turning a normal path such as C:\Users\me\AppData\Local\Temp into the nonexistent /mnt/c/C:/Users/me/AppData/Local/Temp/start-tf.sh; other drives and paths containing spaces fail as well. Consequently, Bash cannot find the generated script and TrueForge does not launch.
Agent Prompt
## Issue description
The generated script is written to an absolute Windows `%TEMP%` path, but the launch command incorrectly creates its Linux path by prepending `/mnt/c/` to that complete Windows path. Convert the exact `$scriptPath` through WSL's `wslpath` and quote the resulting Linux path safely when invoking Bash.
## Issue Context
For example, `C:\Users\me\AppData\Local\Temp\start-tf.sh` currently becomes `/mnt/c/C:/Users/me/AppData/Local/Temp/start-tf.sh`, which does not exist. The conversion must also support non-C drives and spaces in user profile paths.
## Fix Focus Areas
- start.ps1[91-93]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Fixes TrueForge launch in WSL via script file.
CodeAnt-AI Description
Launch TrueForge reliably in WSL
What Changed
Impact
✅ Reliable TrueForge startup in WSL✅ Fewer launch failures from command parsing✅ Clearer startup completion feedback💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.