Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion start.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,16 @@ if ($wslTf -match "missing") {

# Launch TrueForge in WSL
Write-Host " Launching TrueForge in WSL..." -ForegroundColor Yellow
Start-Process powershell -ArgumentList "-NoExit", "-Command", "wsl -d Ubuntu -- bash -c 'export PATH=/usr/bin:/usr/local/bin:`$PATH && cd ~ && npx @truefoundry/trueforge'"
$wslScript = @'
#!/bin/bash
export PATH=/usr/bin:/usr/local/bin:/usr/local/sbin:/usr/sbin:/sbin:$PATH
cd ~
npx @truefoundry/trueforge

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: The launcher omits npx -y, unlike the repository-supported TrueForge launcher. Because the package was installed globally but is not necessarily resolved by npx as an executable package, npx can prompt for confirmation to install it in the new terminal, causing the one-click startup to wait instead of launching unattended. [api mismatch]

Severity Level: Major ⚠️
- ❌ One-click TrueForge startup can block on an interactive npx prompt.
- ⚠️ The WSL terminal requires manual confirmation before serving TrueForge.

Use CodeAnt Skill Fix in Cursor Fix in VSCode Claude

Prompt for AI Agent 🤖
This is a comment left during a code review.

**Path:** start.ps1
**Line:** 89:89
**Comment:**
	*Api Mismatch: The launcher omits `npx -y`, unlike the repository-supported TrueForge launcher. Because the package was installed globally but is not necessarily resolved by `npx` as an executable package, `npx` can prompt for confirmation to install it in the new terminal, causing the one-click startup to wait instead of launching unattended.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
👍 | 👎

'@
$scriptPath = "$env:TEMP\start-tf.sh"
[System.IO.File]::WriteAllText($scriptPath, $wslScript, [System.Text.UTF8Encoding]::new($false))
Start-Process wsl -ArgumentList "-d Ubuntu -- bash -c 'bash /mnt/c/$($env:TEMP -replace '\\','/')/start-tf.sh'"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: The constructed WSL path is invalid for the normal Windows TEMP value, which includes the drive prefix, such as C:\Users\...\AppData\Local\Temp. This produces /mnt/c/C:/Users/.../start-tf.sh, so WSL cannot find the generated script. Convert the Windows path with wslpath or strip the drive prefix and map the actual drive before launching. [logic error]

Severity Level: Major ⚠️
- ❌ TrueForge fails to launch from the one-click Windows startup script.
- ⚠️ The dashboard starts while its required TrueForge terminal remains unavailable.

Use CodeAnt Skill Fix in Cursor Fix in VSCode Claude

Prompt for AI Agent 🤖
This is a comment left during a code review.

**Path:** start.ps1
**Line:** 93:93
**Comment:**
	*Logic Error: The constructed WSL path is invalid for the normal Windows `TEMP` value, which includes the drive prefix, such as `C:\Users\...\AppData\Local\Temp`. This produces `/mnt/c/C:/Users/.../start-tf.sh`, so WSL cannot find the generated script. Convert the Windows path with `wslpath` or strip the drive prefix and map the actual drive before launching.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
👍 | 👎

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Invalid wsl temp path 🐞 Bug ≡ Correctness

The launcher prepends /mnt/c/ to the complete Windows %TEMP% value, turning a normal path such
as C:\Users\me\AppData\Local\Temp into the nonexistent
/mnt/c/C:/Users/me/AppData/Local/Temp/start-tf.sh; other drives and paths containing spaces fail
as well. Consequently, Bash cannot find the generated script and TrueForge does not launch.
Agent Prompt
## Issue description
The generated script is written to an absolute Windows `%TEMP%` path, but the launch command incorrectly creates its Linux path by prepending `/mnt/c/` to that complete Windows path. Convert the exact `$scriptPath` through WSL's `wslpath` and quote the resulting Linux path safely when invoking Bash.

## Issue Context
For example, `C:\Users\me\AppData\Local\Temp\start-tf.sh` currently becomes `/mnt/c/C:/Users/me/AppData/Local/Temp/start-tf.sh`, which does not exist. The conversion must also support non-C drives and spaces in user profile paths.

## Fix Focus Areas
- start.ps1[91-93]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Start-Sleep -Seconds 2
Write-Host " TrueForge terminal opened" -ForegroundColor Green

# Done
Expand Down