-
Notifications
You must be signed in to change notification settings - Fork 0
fix: WSL TrueForge launch #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -82,7 +82,16 @@ if ($wslTf -match "missing") { | |
|
|
||
| # Launch TrueForge in WSL | ||
| Write-Host " Launching TrueForge in WSL..." -ForegroundColor Yellow | ||
| Start-Process powershell -ArgumentList "-NoExit", "-Command", "wsl -d Ubuntu -- bash -c 'export PATH=/usr/bin:/usr/local/bin:`$PATH && cd ~ && npx @truefoundry/trueforge'" | ||
| $wslScript = @' | ||
| #!/bin/bash | ||
| export PATH=/usr/bin:/usr/local/bin:/usr/local/sbin:/usr/sbin:/sbin:$PATH | ||
| cd ~ | ||
| npx @truefoundry/trueforge | ||
| '@ | ||
| $scriptPath = "$env:TEMP\start-tf.sh" | ||
| [System.IO.File]::WriteAllText($scriptPath, $wslScript, [System.Text.UTF8Encoding]::new($false)) | ||
| Start-Process wsl -ArgumentList "-d Ubuntu -- bash -c 'bash /mnt/c/$($env:TEMP -replace '\\','/')/start-tf.sh'" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggestion: The constructed WSL path is invalid for the normal Windows Severity Level: Major
|
||
| Start-Sleep -Seconds 2 | ||
| Write-Host " TrueForge terminal opened" -ForegroundColor Green | ||
|
|
||
| # Done | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: The launcher omits
npx -y, unlike the repository-supported TrueForge launcher. Because the package was installed globally but is not necessarily resolved bynpxas an executable package,npxcan prompt for confirmation to install it in the new terminal, causing the one-click startup to wait instead of launching unattended. [api mismatch]Severity Level: Major⚠️
Prompt for AI Agent 🤖