Skip to content

Resolve DeprecationWarnings and fix CodeCov#3803

Open
shralex wants to merge 1 commit intomainfrom
shralex_warnings_2
Open

Resolve DeprecationWarnings and fix CodeCov#3803
shralex wants to merge 1 commit intomainfrom
shralex_warnings_2

Conversation

@shralex
Copy link
Copy Markdown
Collaborator

@shralex shralex commented May 3, 2026

Resolves observed DeprecationWarning in integration tests by replacing deprecated .value access on nnx Variables with [...] and updating _object__state to _pytree__state. Fix CodeCov, that recently stopped running.

Tests

Tested on TPU VM

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@shralex shralex force-pushed the shralex_warnings_2 branch from ec346e6 to b2e8674 Compare May 3, 2026 04:54
@shralex shralex requested a review from khatwanimohit as a code owner May 3, 2026 05:11
@shralex shralex force-pushed the shralex_warnings_2 branch from 1b215f7 to 0576a58 Compare May 3, 2026 05:13
@shralex shralex changed the title Resolve DeprecationWarnings for .value and _object__state Resolve DeprecationWarnings for .value and _object__state and fix CodeCov May 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/layers/nnx_wrappers.py 61.53% 4 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@shralex shralex force-pushed the shralex_warnings_2 branch from 31446d6 to d33d260 Compare May 3, 2026 05:32
@shralex shralex changed the title Resolve DeprecationWarnings for .value and _object__state and fix CodeCov Resolve DeprecationWarnings and fix CodeCov May 3, 2026
@shralex shralex force-pushed the shralex_warnings_2 branch 3 times, most recently from 8328a70 to 66f96ab Compare May 3, 2026 06:00
@shralex shralex force-pushed the shralex_warnings_2 branch from 66f96ab to d5e5fcf Compare May 3, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant