Repository navigation
Read an even power of a real base as never negative in a limit - #2368
Merged
Rafael-SOWNet merged 1 commit intoNov 4, 2026
Merged
Conversation
1/((x^2)^tanh(1)) at 0 was NaN, the claim that the limit does not exist, where it is +oo from both sides. IsNeverNegative read a base as never negative only for an absolute value, or a real power, product or quotient of never-negative parts, so x^2 was not one. A vanishing power of it to a constant that is not a number, or to an exponent tending to a negative number, was left unevaluated from each side, and the two-sided limit was NaN for the sides not being answered. The same on 2.6.0. An even integer power of a base that TreeAnalyzer.IsRealValued says is real for real x is now never negative; IsNeverNegative takes the variable for it. The base has to be real: sqrt(x)^2 is x, and 1/(((i*x)^2)^tanh(1)), whose base is -x^2, is still not answered. limitcheck at DEPTH=3, seeds 14-36 (11 seeds), master against this: three NaNs answered, (sinh(x)^2)^(sin(x) - 1) and 1/((x^2)^tanh(1)) at seed 36 and sqrt(x^2)^tan(pi - 1) at seed 29, each +oo, and nothing else changed. Suite 18963 passed, AOT and the eight harnesses clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2368 +/- ##
=======================================
Coverage 86.78% 86.78%
=======================================
Files 312 312
Lines 68861 68865 +4
Branches 20066 20067 +1
=======================================
+ Hits 59761 59765 +4
+ Misses 4911 4910 -1
- Partials 4189 4190 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
|
Merged without the two macOS jobs. They never ran: GitHub had no macOS arm64 runner capacity, and each of three re-runs was cancelled with "The job was not acquired by Runner of type hosted even after multiple attempts". No macOS job has started on any branch since 14:31 UTC. In their place:
|
Rafael-SOWNet
deleted the
fix/an-even-power-of-a-real-is-never-negative
branch
November 4, 2026 16:20
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1/((x^2)^tanh(1))at 0 wasNaN, the claim that the limit does not exist. The limit is+oofrom both sides.IsNeverNegativeonly counted a base as never negative when it was an absolute value, or a real power, product or quotient of never-negative parts.x^2was none of those. So a vanishing power of it was left unevaluated from each side when its exponent was a constant other than a number, or tended to a negative number. The two-sided limit was thenNaNbecause neither side had an answer. 2.6.0 gives the same results.An even integer power is now never negative when
TreeAnalyzer.IsRealValuedsays its base is real for realx.IsNeverNegativenow takes the variable so it can ask that. The base has to be real, becausesqrt(x)^2isx.1/(((i*x)^2)^tanh(1))has base-x^2, and it is still not answered. A test pins that.1/((x^2)^tanh(1))at 0NaN; each side unevaluated+oo(sinh(x)^2)^(sin(x) - 1)at 0NaN; each side unevaluated+oosqrt(x^2)^tan(pi - 1)at 0NaN; each side unevaluated+ooMeasured
DEPTH=3on 11 seeds (14, 16, 19, 23, 26, 28, 29, 31, 33, 34, 36), master against this branch: three NaNs are answered, all+oo. Two are at seed 36,1/((x^2)^tanh(1))and(sinh(x)^2)^(sin(x) - 1). One is at seed 29,sqrt(x^2)^tan(pi - 1). Nothing else changed.Recorded in BREAKING-CHANGES.md.
🤖 Generated with Claude Code