Skip to content

Visualizer Refactor - #139

Merged
micahwoodard merged 128 commits into
mainfrom
visualizer-refactor-staging
Sep 11, 2026
Merged

Visualizer Refactor#139
micahwoodard merged 128 commits into
mainfrom
visualizer-refactor-staging

Conversation

@RoboDoig

@RoboDoig RoboDoig commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

This PR refactors the dynamic foraging visualizers to use a full Bonsai ImGui approach according the the requirements outlined in the visualizer refactor milestone

Addresses issues #99, #100, #101, #102, #103, #104, #105.

Individual visualizers take as input an observable source that describes their parent layout group (e.g. tab area, table window) such that visualizers can be reorganised within a parent layout structure. Generally, data is mapped to visualizers by externalized subject names corresponding to the appropriate data source or event.

RoboDoig added 30 commits June 23, 2026 18:14
Switched to time-based visualization so trial-based no longer needed
@RoboDoig

RoboDoig commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator Author

@bruno-f-cruz @micahwoodard - for rotating the image in shader, is free rotation necessary or is it always done in 90 degree increments? Both possible just much more straightforward for 90 degree increments!

@micahwoodard micahwoodard left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get crashing and memory errors without this take until which is why I added originally.

Unhandled Exception: System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
   at OpenTK.Graphics.OpenGL4.GL.DeleteTextures(Int32 n, Int32& textures) in I:\work\github\opentk\src\OpenTK\Graphics\OpenGL4\GL4.cs:line 16159

@micahwoodard

Copy link
Copy Markdown
Collaborator

@RoboDoig I added back the takeuntil to circumvent the AccessViolationException to be able to continue running a mouse for testing today. We can remove and fix with something else though

@RoboDoig RoboDoig mentioned this pull request Sep 4, 2026
@micahwoodard

Copy link
Copy Markdown
Collaborator

@bruno-f-cruz @micahwoodard - for rotating the image in shader, is free rotation necessary or is it always done in 90 degree increments? Both possible just much more straightforward for 90 degree increments!

Oh sorry I missed this. 90 degree increments

@micahwoodard

Copy link
Copy Markdown
Collaborator

@RoboDoig @bruno-f-cruz do we want to just merge this? This branch is what we've been using during testing and what I've been merging fixes into. Just seems like this pr has gotten big and hard to track everything that's going on

@RoboDoig

Copy link
Copy Markdown
Collaborator Author

@micahwoodard yes agreed that it's gotten hard to track, I believe on my end what is still outstanding is dynamically creating the camera visualizers from the cameras specified in the settings, as opposed to them being hard coded on the visualizer. Is there anything else?

@micahwoodard

micahwoodard commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

@RoboDoig I think there a couple of smaller issues like #173, #179, and #111 but ones I think we can address after merging in separate pr's. I would also be fine merging this pr as is and having a separate pr for the dynamic camera visualizers

@micahwoodard

Copy link
Copy Markdown
Collaborator

We ran two session yesterday with latest changes here so I feel okay about merging unless @RoboDoig or @bruno-f-cruz disagree

@micahwoodard
micahwoodard merged commit fba2064 into main Sep 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants