Visualizer Refactor - #139
Conversation
Switched to time-based visualization so trial-based no longer needed
|
@bruno-f-cruz @micahwoodard - for rotating the image in shader, is free rotation necessary or is it always done in 90 degree increments? Both possible just much more straightforward for 90 degree increments! |
…ias-visualization Feat autowater and bias visualization
Guards retracted stage movement
Ensure visualizer is automatically visible on workflow start
micahwoodard
left a comment
There was a problem hiding this comment.
I get crashing and memory errors without this take until which is why I added originally.
Unhandled Exception: System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
at OpenTK.Graphics.OpenGL4.GL.DeleteTextures(Int32 n, Int32& textures) in I:\work\github\opentk\src\OpenTK\Graphics\OpenGL4\GL4.cs:line 16159
|
@RoboDoig I added back the takeuntil to circumvent the AccessViolationException to be able to continue running a mouse for testing today. We can remove and fix with something else though |
…ewarded Fix auto reward is rewarded
Oh sorry I missed this. 90 degree increments |
|
@RoboDoig @bruno-f-cruz do we want to just merge this? This branch is what we've been using during testing and what I've been merging fixes into. Just seems like this pr has gotten big and hard to track everything that's going on |
…sion bumps bonsai version
|
@micahwoodard yes agreed that it's gotten hard to track, I believe on my end what is still outstanding is dynamically creating the camera visualizers from the cameras specified in the settings, as opposed to them being hard coded on the visualizer. Is there anything else? |
|
We ran two session yesterday with latest changes here so I feel okay about merging unless @RoboDoig or @bruno-f-cruz disagree |
This PR refactors the dynamic foraging visualizers to use a full Bonsai ImGui approach according the the requirements outlined in the visualizer refactor milestone
Addresses issues #99, #100, #101, #102, #103, #104, #105.
Individual visualizers take as input an observable source that describes their parent layout group (e.g. tab area, table window) such that visualizers can be reorganised within a parent layout structure. Generally, data is mapped to visualizers by externalized subject names corresponding to the appropriate data source or event.