fix(release): honor skip-release marker only in subject/trailer, not prose#39
Merged
Merged
Conversation
…prose _parse_conventional_commits grepped the ENTIRE HEAD commit body for the skip-release marker, so a commit whose prose merely mentioned that marker (e.g. one explaining the release logic) skipped its own release. PR #38's feat commit did exactly that and was silently skipped — no v0.3.0 was cut. Now the marker is honored only when it appears in the subject line or as a standalone trailer line. Subject and trailer skips still work; mid-sentence mentions no longer trigger a skip. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens the skip-release detector in _parse_conventional_commits.
Bug: it grepped the whole HEAD commit body for the marker, so PR #38 (whose body explains the patch-floor and mentions the marker in prose) silently skipped its own release — no v0.3.0 was cut.
Fix: match the marker only in the subject line (fixed-string) or as a standalone trailer line. Verified: subject-skip ✓, trailer-skip ✓, prose mention ✓ does NOT skip; local _parse on main now returns
minor.Merging this releases v0.3.0 (badges + CHANGELOG + patch-floor from #38, now unblocked).
🤖 Generated with Claude Code