Skip to content

fix(release): honor skip-release marker only in subject/trailer, not prose #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreJorgeLopes merged 1 commit into from
Jun 10, 2026
Merged

fix(release): honor skip-release marker only in subject/trailer, not prose #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions lib/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,15 @@ _parse_conventional_commits() {
return 0
fi

# Check for [skip release] in the HEAD commit only (not the entire range)
local head_msg
# Honor the skip-release marker on the HEAD commit only — and ONLY when it
# appears in the subject line or as a standalone trailer line, NOT mid-prose.
# (A commit whose body merely mentions the marker while explaining the release
# logic must not skip its own release — that footgun silently skipped PR #38.)
local head_msg head_subject
head_msg="$(git -C "$project_dir" log -1 --format='%B' 2>/dev/null || echo "")"
if echo "$head_msg" | grep -qi '\[skip release\]'; then
head_subject="$(echo "$head_msg" | head -1)"
if echo "$head_subject" | grep -qiF '[skip release]' \
|| echo "$head_msg" | grep -qiE '^[[:space:]]*\[skip release\][[:space:]]*$'; then
echo "none"
return 0
fi
Expand Down