[Tooling] Upload CDN builds as drafts, publish in publish_release#2695
Draft
[Tooling] Upload CDN builds as drafts, publish in publish_release#2695
Conversation
1 task
iangmaia
changed the title
…ish_release Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
iangmaia
force-pushed
the
iangmaia/upload-cdn-builds-as-internal-first
branch
from
e74bec3 to
921742d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the release automation to upload Apps CDN artifacts as Internal first (for an internal testing window), and then flips them to External as part of publish_release before the GitHub release is published.
Changes:
- Change Apps CDN uploads to use Internal visibility by default.
- Add
make_cdn_builds_publichelper to find internal builds for a release version and update them to External visibility. - Update release lane prompts and call
make_cdn_builds_publicduringpublish_release.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 tasks
If publish_release is rerun after a partial failure, the builds may already be external. Warn and continue instead of erroring out. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
Contributor
Author
|
Converted to draft until the release-toolkit PRs aren't merged and we can use a new version with both actions. |
… visibility Upload release builds as external+draft, then publish them in publish_release. The CDN plugin hides internal-visibility posts from all API queries, making the previous internal→external approach unworkable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
iangmaia
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
update_apps_cdn_build_metadataaction)list_apps_cdn_buildsaction)How AI was used in this PR
Claude Code was used to implement the Fastfile changes based on a detailed plan I designed. I reviewed all generated code.
Proposed Changes
post_status: 'draft')make_cdn_builds_publichelper that queries the CDN API vialist_apps_cdn_buildsto find draft builds for the release version, then publishes each viaupdate_apps_cdn_build_metadatamake_cdn_builds_publicinpublish_releasebefore publishing the GitHub releasefinalize_releaseprompt to mention the new draft behaviorWhy drafts instead of internal visibility?
Integration testing against the real CDN API revealed that posts with
visibility: internalare completely hidden from all listing queries (by CDN plugin design), making it impossible to find and flip them later. The draft/publish approach works reliably and is idempotent — re-running when no drafts exist is a safe no-op.Testing Instructions
Pre-merge Checklist
🤖 Generated with Claude Code