Skip to content

Ensure the Login URL is using HTTPS#2856

Merged
sjinks merged 3 commits into
Automattic:trunkfrom
dphiffer:fix/dev-env-login-url
May 29, 2026
Merged

Ensure the Login URL is using HTTPS#2856
sjinks merged 3 commits into
Automattic:trunkfrom
dphiffer:fix/dev-env-login-url

Conversation

@dphiffer
Copy link
Copy Markdown
Contributor

@dphiffer dphiffer commented May 27, 2026

Description

One of our developers had a frustrating experience after following the login URL from vip dev-env info and found the resulting editing experience slightly broken when using the currently linked plaintext HTTP WordPress dashboard. This approach assumes there will be a working HTTPS connection available, which may not always be the case. But for the majority of our developers, offering an HTTPS login URL is better and would lead to reduced frustration.

Changelog Description

  • Prefer HTTPS for dev environment login URL.

Changed

  • Show both HTTP and HTTPS versions of the login URL.

Pull request checklist

Steps to Test

  1. Check out PR.
  2. Run npm run build
  3. Run npm link
  4. Run ./dist/bin/vip.js dev-env info
  5. Verify Login URL starts with https://

@sjinks sjinks self-assigned this May 29, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Prefers HTTPS for the dev-environment Login URL printed by vip dev-env info (and after vip dev-env start), while still surfacing the HTTP variant for environments without a working HTTPS proxy. The URL is now constructed via the WHATWG URL API so the autologin key is set as a proper query parameter and the protocol can be toggled cleanly.

Changes:

  • Import EOL from node:os.
  • Rebuild the login URL with new URL( frontEndUrl ) and set vip-dev-autologin via searchParams.
  • Emit both the HTTPS and HTTP login URLs (HTTPS first), separated by EOL.

Comment thread src/lib/dev-environment/dev-environment-lando.ts Outdated
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@sjinks sjinks merged commit 3c498d0 into Automattic:trunk May 29, 2026
16 checks passed
@sjinks
Copy link
Copy Markdown
Member

sjinks commented May 29, 2026

Thank you!

@dphiffer dphiffer deleted the fix/dev-env-login-url branch May 29, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants