Ensure the Login URL is using HTTPS#2856
Merged
Merged
Conversation
sjinks
approved these changes
May 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Prefers HTTPS for the dev-environment Login URL printed by vip dev-env info (and after vip dev-env start), while still surfacing the HTTP variant for environments without a working HTTPS proxy. The URL is now constructed via the WHATWG URL API so the autologin key is set as a proper query parameter and the protocol can be toggled cleanly.
Changes:
- Import
EOLfromnode:os. - Rebuild the login URL with
new URL( frontEndUrl )and setvip-dev-autologinviasearchParams. - Emit both the HTTPS and HTTP login URLs (HTTPS first), separated by
EOL.
|
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
One of our developers had a frustrating experience after following the login URL from
vip dev-env infoand found the resulting editing experience slightly broken when using the currently linked plaintext HTTP WordPress dashboard. This approach assumes there will be a working HTTPS connection available, which may not always be the case. But for the majority of our developers, offering an HTTPS login URL is better and would lead to reduced frustration.Changelog Description
Changed
Pull request checklist
Steps to Test
npm run buildnpm link./dist/bin/vip.js dev-env infohttps://