Skip to content

Ensure the Login URL is using HTTPS #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sjinks merged 3 commits into from
May 29, 2026
Merged

Ensure the Login URL is using HTTPS #2856

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
756bada
Ensure the Login URL is using HTTPS
dphiffer May 27, 2026
0045e8a
refactor: show both https and http login URLs
sjinks May 29, 2026
4590bff
fix: restore `wp-admin/`
sjinks May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/lib/dev-environment/dev-environment-lando.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import Dockerode from 'dockerode';
import { execFile } from 'node:child_process';
import { lookup } from 'node:dns/promises';
import { mkdir, rename, unlink, stat, writeFile } from 'node:fs/promises';
import { cpus, totalmem, userInfo } from 'node:os';
import { cpus, EOL, totalmem, userInfo } from 'node:os';
import path, { dirname } from 'node:path';
import { promisify } from 'node:util';
import { satisfies } from 'semver';
Expand Down Expand Up @@ -670,12 +670,18 @@ export async function landoInfo(

// Add login information
if ( frontEndUrl ) {
let loginUrl = `${ frontEndUrl }wp-admin/`;
const loginURL = new URL( `${ frontEndUrl }wp-admin/` );
if ( options.autologinKey ) {
loginUrl += `?vip-dev-autologin=${ options.autologinKey }`;
loginURL.searchParams.set( 'vip-dev-autologin', options.autologinKey );
}

appInfo[ 'Login URL' ] = loginUrl;
loginURL.protocol = 'http:';
const httpLoginUrl = loginURL.toString();

loginURL.protocol = 'https:';
const httpsLoginUrl = loginURL.toString();

appInfo[ 'Login URL' ] = [ httpsLoginUrl, httpLoginUrl ].join( EOL );
appInfo[ 'Default username' ] = 'vipgo';

// Get the stored password from instance data
Expand Down
Loading