Repository navigation
docs(l1): fix stale v6 upgrade runbook and comments - #25626
Open
spalladino wants to merge 1 commit into
Open
spalladino wants to merge 1 commit into
spalladino wants to merge 1 commit into
Conversation
spalladino
requested review from
iAmMichaelConnor,
just-mitch and
koenmtb1
as code owners
October 8, 2026 17:41
just-mitch
removed their request for review
October 8, 2026 20:20
- Deploy script header described the old deployer-owned-then-transferred flow; the rollup is owned by governance from construction. - State which values verify() does not read back. - Runbook: drop the incorrect 'totalEarmarkedBalance must be 0' precondition (earmarks stay claimable and subsidizeAddress cannot shrink the implicit pool); check availableTo(v5) covers the reservation instead. - Runbook: list the six library deployments and the measured gas, add a verifier bytecode check, fix action numbers, fill in placeholder commands.
spalladino
force-pushed
the
spl/v6-upgrade-docs-fixes
branch
from
October 9, 2026 19:13
cb767bf to
efeb2d4
Compare
spalladino
enabled auto-merge (squash)
October 9, 2026 19:15
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs and comments only, on top of #25601, from reviewing that PR. No Solidity code changes.
Context
Some of the runbook and comments in #25601 predate later design changes, and a few runbook steps would mislead an operator on deploy day:
totalEarmarkedBalanceto be 0 before execution. That contradicts the payload, which earmarks 1.8M to v5 by design, and it is not needed: earmarks stay claimable by their recipient after it stops being canonical, andsubsidizeAddressraises the balance and the earmarked total equally, so it cannot shrink the implicit pool. Anyone could send a 1-token earmark to v5 and an operator following the runbook would hold a valid upgrade.verify()reads back every value. It does not check the entry-queue config, the reward-boost parameters,ethereumSlotDuration, or the verifier's bytecode.Approach
verify()does not check.availableTo(v5)must cover the 1.8M reservation), add an owner check for the old flush rewarder, define$TOKEN, and record a 2026-10-08 baseline.verify()does not cover it and the verifier is immutable.Registry.addRollupis action 7), drop a duplicated owner check, and replace placeholdercastcommands in the post-execution checks with real ones, including reading v5's retuned reward config.V6UpgradePayload.md: rewrite the earmark limitation to match the distributor's behavior.The Sepolia comments in the config table (entry-queue "v5 Sepolia production" values, "all of it un-earmarked") were flagged as possibly stale against live Sepolia, but reviewers disagreed and I did not verify them, so they are unchanged here.