Regenerate Sql and AzureBlob with the corrected Purview parameter name - #227
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Regenerates the SQL Server and Azure Blob connector clients to correct the public C# parameter identifier for the Purview query parameter (fixing the historical purviewAcccountName typo to purviewAccountName) while preserving the wire query key (purviewAccountName).
Changes:
- Regenerated
SqlExtensions.csto rename the affected optional parameter and its XML doc entries. - Regenerated
AzureBlobExtensions.csto apply the same parameter rename across affected operations (plus additional regeneration drift as noted in the PR description). - Documented the breaking identifier rename in
CHANGELOG.md.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Azure.Connectors.Sdk/Generated/SqlExtensions.cs | Regenerated output correcting purviewAcccountName → purviewAccountName in method signatures, docs, and query-param construction. |
| src/Azure.Connectors.Sdk/Generated/AzureBlobExtensions.cs | Regenerated output correcting purviewAcccountName → purviewAccountName across Azure Blob operations (with additional generator drift). |
| CHANGELOG.md | Adds a Breaking Changes entry describing the parameter identifier correction and impact on named-argument callers. |
The shared Purview query parameter carries a triple-c typo in its x-ms-summary (`Purview Acccount Name`) while its `name` field is spelled correctly. The generator derives the C# identifier from the summary, so `purviewAcccountName` reached the public API surface; the wire query key was always correct. AzureUX-BPM PR 16639935 hoists the existing correction out of its documentdb-only gate so it applies to every connector. This regenerates the two affected clients: 12 occurrences in SqlExtensions, 20 in AzureBlobExtensions. Identifier-only change - no request behaviour changes. Rebased onto main after #226 merged. Every one of the 64 changed lines is the Purview correction; the drift AzureBlobExtensions previously carried here is now on main. Zero residual `Acccount` occurrences across all generated clients. Build: 0 errors, 0 warnings. Tests: 935 passed, 0 failed. Co-authored-by: Dobby <dobby@microsoft.com>
daviburg
force-pushed
the
fix/regen-sql-azureblob-purview-summary
branch
from
July 31, 2026 17:07
1f614ea to
ec10d9e
Compare
daviburg
marked this pull request as ready for review
July 31, 2026 17:09
daviburg
enabled auto-merge (squash)
July 31, 2026 17:09
9 tasks
swapnil-nagar
approved these changes
Jul 31, 2026
daviburg
added a commit
that referenced
this pull request
Jul 31, 2026
…gned Version affixes are stripped from identifiers but survived in the documentation derived from the swagger summary and description, so `SqlExtensions` emitted `public class GetTablesResponse` documented as `Response for Get tables (V2)`. AzureUX-BPM PR 16648499 aligns the prose with the identifier actually emitted. These three clients are the demonstrating set for that fix, chosen to exercise all three behaviours rather than to be exhaustive: - Sql 28 -> 2. The motivating example. - Mq 17 -> 0. Uses lowercase `(v2)`, matched case-insensitively. - AzureAD 5 -> 1. Four affixes dropped where the identifier was simplified; the one that remains documents `GetMemberGroupsResponseV2`, which kept its affix, so its summary must keep it too or it becomes indistinguishable from its sibling. Documentation-comment only: all 94 changed lines are doc comments, with no identifier, signature or wire change. Sql was held back while the Purview identifier correction was in flight as #227. That merged, so Sql now regenerates clean and is included. The remaining affected clients settle in the planned full sweep. Build: 0 errors, 0 warnings. Tests: 935 passed, 0 failed. Co-authored-by: Dobby <dobby@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Regenerates
SqlandAzureBlobfrom AzureUX-BPM PR 16639935, which corrects the Purview parameter identifier on the public API surface.The shared Purview query parameter declares
"name": "purviewAccountName"correctly but carries"x-ms-summary": "Purview Acccount Name"ΓÇö triple c. The generator derives the C# parameter identifier fromx-ms-summaryrather than fromname, so the typo became part of the shipped API while the wire query key was always correct. The generator already had this correction but gated it behinddocumentdb; the misspelling lives in a$ref-shared global parameter, so every other importer kept emitting it.This is an identifier-only change. No request behaviour changes. Callers passing the parameter positionally are unaffected; callers using a named argument must rename it.
Changes
SqlExtensions.csAzureBlobExtensions.csAll 64 changed lines are the Purview correction ΓÇö zero unrelated drift.
CHANGELOG.mdrecords the rename under Breaking Changes.Rebased onto
mainafter #226 merged. An earlier revision of this PR carried an additional 169 lines inAzureBlobExtensions.cs; that was #226's regeneration drift, which is now onmain, so the diff here has collapsed to the fix itself. Verified that no generator commit landed between #226's generator base (729bc0651c) and this PR's (e7c75d413f), so nothing else could be folded in.Both clients are regenerated together deliberately: correcting only
Sqlwould leaveAzureBlobinconsistent for the same shared parameter.Testing
Unit tests added/updated
All existing tests pass (
dotnet test)Manual testing (describe below if applicable)
dotnet build: 0 errors, 0 warnings.935 tests pass, 0 failures.
Generated from the BPM branch at commit
900f4c28e0with--directClient --connectors=sql,azureblob,documentdbagainst the pinned 1596-entry ARM cache.documentdbwas generated alongside to confirm it is unaffected ΓÇö it was already covered by the old gate and regenerates byte-identical.Zero residual
Acccountoccurrences across all generated clients, not just the two changed here.No unit tests added: this PR contains only generated output. The generator behaviour is covered by two new tests in the paired BPM PR, one of which was explicitly verified non-vacuous by restoring the connector gate and watching it fail.
Checklist
src/**/Generated/(see CONTRIBUTING.md)release_notes.mdupdated (if shipping a new version, clear previous version notes)eng/build/Version.props(if shipping a new version)The
Generated/checkbox is intentionally left unchecked: this is a generator-driven regeneration, the sanctioned way those files change. No file was hand-edited.AzureUX-BPM PR 16639935 merged to master as
1599eedd77, so this is unblocked.Authored with Dobby agent.