Skip to content

Regenerate Sql and AzureBlob with the corrected Purview parameter name #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daviburg merged 1 commit into from
Jul 31, 2026
+34 −32
Merged

Regenerate Sql and AzureBlob with the corrected Purview parameter name #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

The remaining 71 regenerated clients carry accumulated output from generator fixes that merged after their last regeneration, rather than new behaviour introduced here. (AzureUX-BPM PR 16618864)

- **`purviewAcccountName` parameter corrected to `purviewAccountName` on SQL Server and Azure Blob Storage** — the shared Purview query parameter declares its `name` correctly but carries a triple-c typo in its `x-ms-summary`, and the generator derives the C# identifier from the summary. The misspelling therefore reached the public API surface while the wire query key was always correct, so this changes the identifier only, not request behaviour. Callers passing the parameter positionally are unaffected; callers using a named argument must rename it. Affects 12 occurrences in `SqlExtensions` and 20 in `AzureBlobExtensions`. (AzureUX-BPM PR 16639935)

- **SQL Server metadata methods now address the default dataset; the server- and database-scoped forms moved to `V2` names** — the unversioned operation owns the unversioned method name, matching the Python SDK. Existing callers must rename:

| Before | After |
Expand Down
40 changes: 20 additions & 20 deletions src/Azure.Connectors.Sdk/Generated/AzureBlobExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1010,10 +1010,10 @@ public virtual async Task<List<SharedAccessSignatureBlobPolicy>> GetAccessPolici
/// <param name="blob">Blob</param>
/// <param name="inferContentType">Infer content type</param>
/// <param name="extractMIPLabels">Extract MIP Labels</param>
/// <param name="purviewAcccountName">Purview Acccount Name</param>
/// <param name="purviewAccountName">Purview Account Name</param>
/// <param name="cancellationToken">Cancellation token.</param>
/// <returns>The Get blob content (V2) response.</returns>
public virtual async Task<byte[]> GetFileContentAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string blob, bool? inferContentType = default, bool? extractMIPLabels = default, string purviewAcccountName = default, CancellationToken cancellationToken = default)
public virtual async Task<byte[]> GetFileContentAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string blob, bool? inferContentType = default, bool? extractMIPLabels = default, string purviewAccountName = default, CancellationToken cancellationToken = default)
{
using var activity = AzureBlobClient.ConnectorActivitySource.StartActivity("AzureBlobClient.GetFileContentAsync");
try
Expand All @@ -1027,8 +1027,8 @@ public virtual async Task<byte[]> GetFileContentAsync([DynamicValues("GetDataSet
queryParams.Add($"inferContentType={Uri.EscapeDataString(inferContentType.Value.ToString())}");
if (extractMIPLabels.HasValue)
queryParams.Add($"extractSensitivityLabel={Uri.EscapeDataString(extractMIPLabels.Value.ToString())}");
if (purviewAcccountName != default)
queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAcccountName.ToString())}");
if (purviewAccountName != default)
queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAccountName.ToString())}");
var path = $"/v2/datasets/{Uri.EscapeDataString(Uri.EscapeDataString(storageAccountNameOrBlobEndpoint.ToString()))}/files/{Uri.EscapeDataString(Uri.EscapeDataString(blob.ToString()))}/content" + (queryParams.Count > 0 ? "?" + string.Join("&", queryParams) : "");
return await this
.CallConnectorAsync<byte[]>(HttpMethod.Get, path, cancellationToken: cancellationToken)
Expand All @@ -1050,10 +1050,10 @@ public virtual async Task<byte[]> GetFileContentAsync([DynamicValues("GetDataSet
/// <param name="blobPath">Blob path</param>
/// <param name="inferContentType">Infer content type</param>
/// <param name="extractMIPLabels">Extract MIP Labels</param>
/// <param name="purviewAcccountName">Purview Acccount Name</param>
/// <param name="purviewAccountName">Purview Account Name</param>
/// <param name="cancellationToken">Cancellation token.</param>
/// <returns>The Get blob content using path (V2) response.</returns>
public virtual async Task<byte[]> GetFileContentByPathAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string blobPath, bool? inferContentType = default, bool? extractMIPLabels = default, string purviewAcccountName = default, CancellationToken cancellationToken = default)
public virtual async Task<byte[]> GetFileContentByPathAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string blobPath, bool? inferContentType = default, bool? extractMIPLabels = default, string purviewAccountName = default, CancellationToken cancellationToken = default)
{
using var activity = AzureBlobClient.ConnectorActivitySource.StartActivity("AzureBlobClient.GetFileContentByPathAsync");
try
Expand All @@ -1069,8 +1069,8 @@ public virtual async Task<byte[]> GetFileContentByPathAsync([DynamicValues("GetD
queryParams.Add($"inferContentType={Uri.EscapeDataString(inferContentType.Value.ToString())}");
if (extractMIPLabels.HasValue)
queryParams.Add($"extractSensitivityLabel={Uri.EscapeDataString(extractMIPLabels.Value.ToString())}");
if (purviewAcccountName != default)
queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAcccountName.ToString())}");
if (purviewAccountName != default)
queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAccountName.ToString())}");
var path = $"/v2/datasets/{Uri.EscapeDataString(Uri.EscapeDataString(storageAccountNameOrBlobEndpoint.ToString()))}/GetFileContentByPath" + (queryParams.Count > 0 ? "?" + string.Join("&", queryParams) : "");
return await this
.CallConnectorAsync<byte[]>(HttpMethod.Get, path, cancellationToken: cancellationToken)
Expand All @@ -1091,10 +1091,10 @@ public virtual async Task<byte[]> GetFileContentByPathAsync([DynamicValues("GetD
/// <param name="storageAccountNameOrBlobEndpoint">Storage account name or blob endpoint</param>
/// <param name="blob">Blob</param>
/// <param name="extractMIPLabels">Extract MIP Labels</param>
/// <param name="purviewAcccountName">Purview Acccount Name</param>
/// <param name="purviewAccountName">Purview Account Name</param>
/// <param name="cancellationToken">Cancellation token.</param>
/// <returns>The Get Blob Metadata (V2) response.</returns>
public virtual async Task<DataWithSensitivityLabelInfo> GetFileMetadataAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string blob, bool? extractMIPLabels = default, string purviewAcccountName = default, CancellationToken cancellationToken = default)
public virtual async Task<DataWithSensitivityLabelInfo> GetFileMetadataAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string blob, bool? extractMIPLabels = default, string purviewAccountName = default, CancellationToken cancellationToken = default)
{
using var activity = AzureBlobClient.ConnectorActivitySource.StartActivity("AzureBlobClient.GetFileMetadataAsync");
try
Expand All @@ -1106,8 +1106,8 @@ public virtual async Task<DataWithSensitivityLabelInfo> GetFileMetadataAsync([Dy
var queryParams = new List<string>();
if (extractMIPLabels.HasValue)
queryParams.Add($"extractSensitivityLabel={Uri.EscapeDataString(extractMIPLabels.Value.ToString())}");
if (purviewAcccountName != default)
queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAcccountName.ToString())}");
if (purviewAccountName != default)
queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAccountName.ToString())}");
var path = $"/v2/datasets/{Uri.EscapeDataString(Uri.EscapeDataString(storageAccountNameOrBlobEndpoint.ToString()))}/files/{Uri.EscapeDataString(Uri.EscapeDataString(blob.ToString()))}" + (queryParams.Count > 0 ? "?" + string.Join("&", queryParams) : "");
return await this
.CallConnectorAsync<DataWithSensitivityLabelInfo>(HttpMethod.Get, path, cancellationToken: cancellationToken)
Expand All @@ -1128,10 +1128,10 @@ public virtual async Task<DataWithSensitivityLabelInfo> GetFileMetadataAsync([Dy
/// <param name="storageAccountNameOrBlobEndpoint">Storage account name or blob endpoint</param>
/// <param name="blobPath">Blob path</param>
/// <param name="extractMIPLabels">Extract MIP Labels</param>
/// <param name="purviewAcccountName">Purview Acccount Name</param>
/// <param name="purviewAccountName">Purview Account Name</param>
/// <param name="cancellationToken">Cancellation token.</param>
/// <returns>The Get Blob Metadata using path (V2) response.</returns>
public virtual async Task<DataWithSensitivityLabelInfo> GetFileMetadataByPathAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string blobPath, bool? extractMIPLabels = default, string purviewAcccountName = default, CancellationToken cancellationToken = default)
public virtual async Task<DataWithSensitivityLabelInfo> GetFileMetadataByPathAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string blobPath, bool? extractMIPLabels = default, string purviewAccountName = default, CancellationToken cancellationToken = default)
{
using var activity = AzureBlobClient.ConnectorActivitySource.StartActivity("AzureBlobClient.GetFileMetadataByPathAsync");
try
Expand All @@ -1145,8 +1145,8 @@ public virtual async Task<DataWithSensitivityLabelInfo> GetFileMetadataByPathAsy
queryParams.Add($"path={Uri.EscapeDataString(blobPath.ToString())}");
if (extractMIPLabels.HasValue)
queryParams.Add($"extractSensitivityLabel={Uri.EscapeDataString(extractMIPLabels.Value.ToString())}");
if (purviewAcccountName != default)
queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAcccountName.ToString())}");
if (purviewAccountName != default)
queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAccountName.ToString())}");
var path = $"/v2/datasets/{Uri.EscapeDataString(Uri.EscapeDataString(storageAccountNameOrBlobEndpoint.ToString()))}/GetFileByPath" + (queryParams.Count > 0 ? "?" + string.Join("&", queryParams) : "");
return await this
.CallConnectorAsync<DataWithSensitivityLabelInfo>(HttpMethod.Get, path, cancellationToken: cancellationToken)
Expand All @@ -1169,10 +1169,10 @@ public virtual async Task<DataWithSensitivityLabelInfo> GetFileMetadataByPathAsy
/// <param name="pagingMarker">Paging Marker</param>
/// <param name="flatListing">Flat Listing</param>
/// <param name="extractMIPLabels">Extract MIP Labels</param>
/// <param name="purviewAcccountName">Purview Acccount Name</param>
/// <param name="purviewAccountName">Purview Account Name</param>
/// <param name="cancellationToken">Cancellation token.</param>
/// <returns>The Lists blobs (V2) response.</returns>
public virtual async Task<ListOfBlobsWithSensitivityLabels> ListFolderAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string folder, string pagingMarker = default, bool? flatListing = default, bool? extractMIPLabels = default, string purviewAcccountName = default, CancellationToken cancellationToken = default)
public virtual async Task<ListOfBlobsWithSensitivityLabels> ListFolderAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string folder, string pagingMarker = default, bool? flatListing = default, bool? extractMIPLabels = default, string purviewAccountName = default, CancellationToken cancellationToken = default)
{
using var activity = AzureBlobClient.ConnectorActivitySource.StartActivity("AzureBlobClient.ListFolderAsync");
try
Expand All @@ -1188,8 +1188,8 @@ public virtual async Task<ListOfBlobsWithSensitivityLabels> ListFolderAsync([Dyn
queryParams.Add($"useFlatListing={Uri.EscapeDataString(flatListing.Value.ToString())}");
if (extractMIPLabels.HasValue)
queryParams.Add($"extractSensitivityLabel={Uri.EscapeDataString(extractMIPLabels.Value.ToString())}");
if (purviewAcccountName != default)
queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAcccountName.ToString())}");
if (purviewAccountName != default)
queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAccountName.ToString())}");
var path = $"/v2/datasets/{Uri.EscapeDataString(Uri.EscapeDataString(storageAccountNameOrBlobEndpoint.ToString()))}/foldersV2/{Uri.EscapeDataString(Uri.EscapeDataString(folder.ToString()))}" + (queryParams.Count > 0 ? "?" + string.Join("&", queryParams) : "");
return await this
.CallConnectorAsync<ListOfBlobsWithSensitivityLabels>(HttpMethod.Get, path, cancellationToken: cancellationToken)
Expand Down
Loading
Loading